From: Joe Perches <joe@perches.com>
To: Paolo Valente <paolo.valente@unimore.it>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
"David S. Miller" <davem@davemloft.net>,
shemminger@vyatta.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, fchecconi@gmail.com,
rizzo@iet.unipi.it
Subject: Re: [PATCH BUGFIX] pkt_sched: sch_qfq: remove a source of high packet delay/jitter
Date: Mon, 15 Jul 2013 11:12:22 -0700 [thread overview]
Message-ID: <1373911942.2062.24.camel@joe-AO722> (raw)
In-Reply-To: <1373911290-6237-1-git-send-email-paolo.valente@unimore.it>
On Mon, 2013-07-15 at 20:01 +0200, Paolo Valente wrote:
> QFQ+ inherits from QFQ a design choice that may cause a high packet
> delay/jitter and a severe short-term unfairness.
[]
> diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c
[]
> @@ -189,6 +188,7 @@ struct qfq_sched {
> struct qfq_aggregate *in_serv_agg; /* Aggregate being served. */
> u32 num_active_agg; /* Num. of active aggregates */
> u32 wsum; /* weight sum */
> + unsigned long iwsum; /* inverse weight sum*/
This is a different size for 32/64 bit compiles
and may be better as u32.
next prev parent reply other threads:[~2013-07-15 18:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 18:01 [PATCH BUGFIX] pkt_sched: sch_qfq: remove a source of high packet delay/jitter Paolo Valente
2013-07-15 18:12 ` Joe Perches [this message]
2013-07-16 6:46 ` Paolo Valente
2013-07-16 6:52 ` Paolo Valente
2013-07-18 20:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373911942.2062.24.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=fchecconi@gmail.com \
--cc=jhs@mojatatu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paolo.valente@unimore.it \
--cc=rizzo@iet.unipi.it \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).