Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: fix comment above build_skb()
Date: Tue, 23 Jul 2013 11:54:22 -0700	[thread overview]
Message-ID: <1374605662.3449.49.camel@edumazet-glaptop> (raw)
In-Reply-To: <CAGVrzcZ6=591=sY6kVVrwy4BHN_0LoMZ=u2yz88QyBUvtSOydA@mail.gmail.com>

On Tue, 2013-07-23 at 19:04 +0100, Florian Fainelli wrote:

> Sure, would something like:
> 
> "@data must have been allocated by kmalloc() if frag_size is 0,
> otherwise any data buffer (vmalloc, DMA..) is suitable"
> 

Actually not, the other case must be a page frag, because we are going
to use get_page() and put_page() during skb lifetime.

netlink case is really special/hacky, because it makes sure those
get_page()/put_page() calls wont ever happen.

      parent reply	other threads:[~2013-07-23 18:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23 15:39 [PATCH] net: fix comment above build_skb() Florian Fainelli
2013-07-23 15:49 ` Eric Dumazet
2013-07-23 18:04   ` Florian Fainelli
2013-07-23 18:46     ` Ben Hutchings
2013-07-23 18:54     ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374605662.3449.49.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox