netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Fabio Baltieri <fabio.baltieri@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	linux-wireless@lists.infradead.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mac80211: use oneshot blink API for LED triggers
Date: Wed, 24 Jul 2013 10:14:25 +0200	[thread overview]
Message-ID: <1374653665.8180.0.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1374624581-6012-2-git-send-email-fabio.baltieri@gmail.com> (sfid-20130724_020950_576315_9E59DD81)

On Wed, 2013-07-24 at 02:09 +0200, Fabio Baltieri wrote:
> Changes mac80211 LED trigger code to use the generic
> led_trigger_blink_oneshot() API for transmit and receive activity
> indication.
> 
> This gives a better feedback to the user, as with the new API each
> activity event results in a visible blink, while a constant traffic
> results in a continuous blink at constant rate.

This seems a little pointless since our throughput-based trigger can do
very similar (but somewhat better) behaviour? Maybe that should just be
the default instead, with some sane default setup values?

(Regardless of that, you also have indentation problems in your patch)

johannes

  reply	other threads:[~2013-07-24  8:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-24  0:09 [PATCH] mac80211: use oneshot blink API for LED triggers Fabio Baltieri
2013-07-24  0:09 ` Fabio Baltieri
2013-07-24  8:14   ` Johannes Berg [this message]
2013-07-24  8:53     ` Fabio Baltieri
     [not found]       ` <20130724085337.GA7096-lYxsXyORJ9v/PtFMR13I2A@public.gmane.org>
2013-07-25  7:58         ` Johannes Berg
2013-07-25  9:58           ` Fabio Baltieri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374653665.8180.0.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=fabio.baltieri@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@lists.infradead.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).