Re: [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A

Grant Grundler
2013-07-22T18:29:16Z

On Mon, Jul 22, 2013 at 10:07 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
...
> I guess that if a driver does not advertise NETIF_F_SG, this
> skb_linearize() call is not needed : All frames reaching your xmit
> function should already be linear

As Ben Hutchings pointed out, hw_features is still setting this...but
I'm not sure how that matters.

ax88179_set_features() doesn't allow setting SG or TSO features. But
I expect it would be "not too difficult" to add such that ethtool
could set those features after boot. Or perhaps add a driver module
parameter to set these features. I just guessing the skb_linearize()
could be removed until set_features support for SG and/or TSO is
added. Is that correct?

thanks,
grant