Re: [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A

Eric Dumazet
2013-07-23T23:56:53Z

On Tue, 2013-07-23 at 16:46 -0700, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Mon, 22 Jul 2013 23:10:27 -0700
>
> > On Mon, 2013-07-22 at 20:47 +0100, Ben Hutchings wrote:
> >> The real solution would be for someone to add SG support to the usbnet
> >> core. Trying to support 1GbE with only linear skbs is not a great
> >> idea... and it can only be a matter of time before there is USB ultra
> >> speed (or whatever comes after 'super') with 10GbE devices...
> >>
> >
> > This sounds a good idea.
> >
> > Is anybody working on adding SG to usbnet ?
>
> This is a good long-term plan, but right now we have to do something
> reasonable.
>
> A quick scan shows that smsc75xx, smsc95xx, and ax88179_178a all have
> this problem.
>
> Instead of the patch starting this thread, I'd like to see one that
> hits all three drivers and removes all SG and TSO features bits from
> both the ->features _and_ ->hw_features settings.
>
> Could someone toss that together quickly?

Yes, I can prepare this patch.