Re: [patch net-next v5 0/4] export device physical port id to userspace

[Jeff Kirsher <jeffrey.t.kirsher@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2299 bytes --]

On Fri, 2013-07-26 at 14:09 +0200, Jiri Pirko wrote:
> This patchset is based on patch by Narendra_K@Dell.com
> Once device which can change phys port id during its lifetime adopts this,
> NETDEV_CHANGEPHYSPORTID event will be added and driver will call
> call_netdevice_notifiers(NETDEV_NETDEV_CHANGEPHYSPORTID, dev) to propagate
> the change to userspace.
> 
> v1->v2: as suggested by Ben, handle -EOPNOTSUPP in rtnl code (wrapped up ndo call)
> v2->v3: adjusted patch 1 commit message
> v3->v4: used "%phN" for sysfs printf as suggested by DaveM
>         added igb/igbvf implementation as requested by Or Gerlitz
> v4->v5: used prandom_u32 to generate id in igb_probe
> 	removed duplicate code in ibgvf_probe
> 	pushed dev_err string into one line in igbvf_refresh_ppid
> 
> Jiri Pirko (4):
>   net: add ndo to get id of physical port of the device
>   rtnl: export physical port id via RT netlink
>   net: export physical port id via sysfs
>   igb/igbvf: implement ndo_get_phys_port_id
> 

Jiri-
I do not want to hold up the entire series, especially since three of
the four patches are not against our drivers, but I would like to have
these changes tested in our validation labs.

I will apply the series internally for testing.  In the meantime, if I
get an ACK from Carolyn Wyborny and Greg Rose on the igb/igbvf patch, I
am good with Dave applying the series.

>  drivers/net/ethernet/intel/igb/e1000_mbx.h |  1 +
>  drivers/net/ethernet/intel/igb/igb.h       |  2 ++
>  drivers/net/ethernet/intel/igb/igb_main.c  | 29 +++++++++++++++++++++-
>  drivers/net/ethernet/intel/igbvf/igbvf.h   |  3 +++
>  drivers/net/ethernet/intel/igbvf/mbx.h     |  1 +
>  drivers/net/ethernet/intel/igbvf/netdev.c  | 40 ++++++++++++++++++++++++++++++
>  drivers/net/ethernet/intel/igbvf/vf.c      | 34 +++++++++++++++++++++++++
>  drivers/net/ethernet/intel/igbvf/vf.h      |  1 +
>  include/linux/netdevice.h                  | 20 +++++++++++++++
>  include/uapi/linux/if_link.h               |  1 +
>  net/core/dev.c                             | 18 ++++++++++++++
>  net/core/net-sysfs.c                       | 22 ++++++++++++++++
>  net/core/rtnetlink.c                       | 25 ++++++++++++++++++-
>  13 files changed, 195 insertions(+), 2 deletions(-)


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]