* [PATCH net-next] bonding: remove bond_resend_igmp_join_requests read_unlock leftover
@ 2013-07-27 17:10 Nikolay Aleksandrov
2013-07-27 20:07 ` Jiri Pirko
0 siblings, 1 reply; 3+ messages in thread
From: Nikolay Aleksandrov @ 2013-07-27 17:10 UTC (permalink / raw)
To: netdev; +Cc: andy, fubar, davem
After commit 4aa5dee4d9 ("net: convert resend IGMP to notifier event") we
have 1 read_unlock in bond_resend_igmp_join_requests which isn't paired
with a read_lock because it's removed by that commit.
Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
---
drivers/net/bonding/bond_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index f584352..da3af63 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -739,7 +739,6 @@ static void bond_resend_igmp_join_requests(struct bonding *bond)
queue_delayed_work(bond->wq, &bond->mcast_work, HZ/5);
}
write_unlock_bh(&bond->curr_slave_lock);
- read_unlock(&bond->lock);
}
static void bond_resend_igmp_join_requests_delayed(struct work_struct *work)
--
1.8.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] bonding: remove bond_resend_igmp_join_requests read_unlock leftover
2013-07-27 17:10 [PATCH net-next] bonding: remove bond_resend_igmp_join_requests read_unlock leftover Nikolay Aleksandrov
@ 2013-07-27 20:07 ` Jiri Pirko
2013-07-28 8:08 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Pirko @ 2013-07-27 20:07 UTC (permalink / raw)
To: Nikolay Aleksandrov; +Cc: netdev, andy, fubar, davem
Sat, Jul 27, 2013 at 07:10:10PM CEST, nikolay@redhat.com wrote:
>After commit 4aa5dee4d9 ("net: convert resend IGMP to notifier event") we
>have 1 read_unlock in bond_resend_igmp_join_requests which isn't paired
>with a read_lock because it's removed by that commit.
Oups
>
>Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
Reviewed-by: Jiri Pirko <jiri@resnulli.us>
>---
> drivers/net/bonding/bond_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index f584352..da3af63 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -739,7 +739,6 @@ static void bond_resend_igmp_join_requests(struct bonding *bond)
> queue_delayed_work(bond->wq, &bond->mcast_work, HZ/5);
> }
> write_unlock_bh(&bond->curr_slave_lock);
>- read_unlock(&bond->lock);
> }
>
> static void bond_resend_igmp_join_requests_delayed(struct work_struct *work)
>--
>1.8.1.4
>
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] bonding: remove bond_resend_igmp_join_requests read_unlock leftover
2013-07-27 20:07 ` Jiri Pirko
@ 2013-07-28 8:08 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-07-28 8:08 UTC (permalink / raw)
To: jiri; +Cc: nikolay, netdev, andy, fubar
From: Jiri Pirko <jiri@resnulli.us>
Date: Sat, 27 Jul 2013 22:07:54 +0200
> Sat, Jul 27, 2013 at 07:10:10PM CEST, nikolay@redhat.com wrote:
>>After commit 4aa5dee4d9 ("net: convert resend IGMP to notifier event") we
>>have 1 read_unlock in bond_resend_igmp_join_requests which isn't paired
>>with a read_lock because it's removed by that commit.
>
> Oups
>
>>
>>Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
> Reviewed-by: Jiri Pirko <jiri@resnulli.us>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-28 8:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-27 17:10 [PATCH net-next] bonding: remove bond_resend_igmp_join_requests read_unlock leftover Nikolay Aleksandrov
2013-07-27 20:07 ` Jiri Pirko
2013-07-28 8:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).