From: "Nithin Nayak Sujir" <nsujir@broadcom.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org,
"Nithin Nayak Sujir" <nsujir@broadcom.com>,
"Michael Chan" <mchan@broadcom.com>
Subject: [PATCH net-next 1/6] tg3: Remove incorrect switch to aux power
Date: Mon, 29 Jul 2013 13:58:35 -0700 [thread overview]
Message-ID: <1375131520-1746-2-git-send-email-nsujir@broadcom.com> (raw)
In-Reply-To: <1375131520-1746-1-git-send-email-nsujir@broadcom.com>
During probe, the driver is incorrectly switching the power to Vaux on
the 5717 and later devices. At this point, we are in D0 state and
drawing maximum power. We also definitely have Vmain available. It
doesn't make sense to switch to Vaux since it has a lesser maximum power
draw and we might go over the limit. On a new system, we observe that
not all ports are recognized in some of the slots with this call in
place.
Signed-off-by: Nithin Nayak Sujir <nsujir@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
---
drivers/net/ethernet/broadcom/tg3.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index d964f30..2e4bf5f 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -17547,11 +17547,6 @@ static int tg3_init_one(struct pci_dev *pdev,
tg3_asic_rev(tp) == ASIC_REV_5762)
tg3_flag_set(tp, PTP_CAPABLE);
- if (tg3_flag(tp, 5717_PLUS)) {
- /* Resume a low-power mode */
- tg3_frob_aux_power(tp, false);
- }
-
tg3_timer_init(tp);
tg3_carrier_off(tp);
--
1.8.1.4
next prev parent reply other threads:[~2013-07-29 20:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 20:58 [PATCH net-next 0/6] tg3: Misc changes Nithin Nayak Sujir
2013-07-29 20:58 ` Nithin Nayak Sujir [this message]
2013-07-29 20:58 ` [PATCH net-next 2/6] tg3: Allow NVRAM programming when interface is down Nithin Nayak Sujir
2013-07-29 20:58 ` [PATCH net-next 3/6] tg3: Implement the shutdown handler Nithin Nayak Sujir
2013-07-29 20:58 ` [PATCH net-next 4/6] tg3: Enable support for timesync gpio output Nithin Nayak Sujir
2013-07-29 20:58 ` [PATCH net-next 5/6] tg3: Fix UDP fragments treated as RMCP Nithin Nayak Sujir
2013-07-29 20:58 ` [PATCH net-next 6/6] tg3: Update version to 3.133 Nithin Nayak Sujir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375131520-1746-2-git-send-email-nsujir@broadcom.com \
--to=nsujir@broadcom.com \
--cc=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).