From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [Patch net-next] tcp_metrics: rearrange fields to avoid holes Date: Wed, 31 Jul 2013 11:13:22 +0800 Message-ID: <1375240402.22980.5.camel@cr0> References: <1375238905-6423-1-git-send-email-amwang@redhat.com> <1375240090.10515.53.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Yuchung Cheng , Neal Cardwell To: Eric Dumazet Return-path: Received: from mx1.redhat.com ([209.132.183.28]:30227 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758907Ab3GaDNc (ORCPT ); Tue, 30 Jul 2013 23:13:32 -0400 In-Reply-To: <1375240090.10515.53.camel@edumazet-glaptop> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2013-07-30 at 20:08 -0700, Eric Dumazet wrote: > > Oh well, this patch is pure noise... > > Mind to be specific? I know saving 8 bytes is not interesting for you, but it is for me, since I need some room in struct tcp_metrics_block for union inet_addr. With this patch, I don't have to make struct tcp_metrics_block expand to 3 cachelines. :)