From: Cong Wang <amwang@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Yuchung Cheng <ycheng@google.com>,
Neal Cardwell <ncardwell@google.com>
Subject: Re: [Patch net-next] tcp_metrics: rearrange fields to avoid holes
Date: Wed, 31 Jul 2013 11:37:08 +0800 [thread overview]
Message-ID: <1375241828.22980.6.camel@cr0> (raw)
In-Reply-To: <1375241072.10515.59.camel@edumazet-glaptop>
On Tue, 2013-07-30 at 20:24 -0700, Eric Dumazet wrote:
> On Wed, 2013-07-31 at 11:13 +0800, Cong Wang wrote:
> > On Tue, 2013-07-30 at 20:08 -0700, Eric Dumazet wrote:
> > >
> > > Oh well, this patch is pure noise...
> > >
> > >
> >
> > Mind to be specific?
> >
> > I know saving 8 bytes is not interesting for you, but it is for me,
> > since I need some room in struct tcp_metrics_block for union inet_addr.
> > With this patch, I don't have to make struct tcp_metrics_block expand to
> > 3 cachelines. :)
>
> Do you see how this explanation is rather different than the one you
> gave in the changelog ?
>
> Its 3 lines, instead of all this pahole noise.
So, you mean this patch only makes sense after my union inet_addr? If
so, I will merge it into my inet_addr patch.
>
> And it would be more logical to put the "unsigned long last_syn_loss" at
> the beginning of the structure, instead after an array of 17 bytes.
>
Agreed.
Thanks!
next prev parent reply other threads:[~2013-07-31 3:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 2:48 [Patch net-next] tcp_metrics: rearrange fields to avoid holes Cong Wang
2013-07-31 3:08 ` Eric Dumazet
2013-07-31 3:13 ` Cong Wang
2013-07-31 3:24 ` Eric Dumazet
2013-07-31 3:35 ` Joe Perches
2013-07-31 3:40 ` Cong Wang
2013-07-31 3:37 ` Cong Wang [this message]
2013-07-31 3:57 ` Eric Dumazet
2013-07-31 6:26 ` David Miller
2013-08-01 2:48 ` Cong Wang
2013-08-01 7:15 ` David Miller
2013-08-01 8:13 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375241828.22980.6.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).