From: Oliver Neukum <oneukum@suse.de>
To: David Miller <davem@davemloft.net>
Cc: sam8641@gmail.com, mlindner@marvell.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sky2: detect and prevent kernel panic from a possible faulty hardware
Date: Wed, 31 Jul 2013 10:18:13 +0200 [thread overview]
Message-ID: <1375258693.17175.4.camel@linux-fkkt.site> (raw)
In-Reply-To: <20130730.161906.1898764862564749288.davem@davemloft.net>
On Tue, 2013-07-30 at 16:19 -0700, David Miller wrote:
> From: Samuel Williams <sam8641@gmail.com>
> Date: Sat, 27 Jul 2013 15:35:54 -0500
>
> > A possible faulty hardware might interrupt with a status of 0xffffffff which
> > may kernel panic if sky2 driver tries to handle it. Detecting this problem
> > may avoid kernel panic.
> >
> > Signed-off-by: Samuel Williams <sam8641@gmail.com>
>
> Sure, but then the device is basically just going to stop.
>
> I think this change needs to be more comprehensive, for example it
> needs to fully reset the device and try to get it operational again.
But sky2 is used in some hotremovable cards. You can hit the window
for this race. It is unlikely but still this simple check fixes a bug.
Regards
Oliver
prev parent reply other threads:[~2013-07-31 8:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-27 20:35 [PATCH] sky2: detect and prevent kernel panic from a possible faulty hardware Samuel Williams
2013-07-30 23:19 ` David Miller
2013-07-30 23:32 ` Stephen Hemminger
2013-07-31 8:18 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375258693.17175.4.camel@linux-fkkt.site \
--to=oneukum@suse.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=sam8641@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).