From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Laura Mihaela Vasilescu <laura.vasilescu@rosedu.org>
Cc: netdev@vger.kernel.org, carolyn.wyborny@intel.com,
anjali.singhai@intel.com, alexander.h.duyck@intel.com
Subject: Re: [PATCH 1/2] igb: Add macro for size of RETA indirection table
Date: Wed, 31 Jul 2013 02:14:54 -0700 [thread overview]
Message-ID: <1375262094.2877.31.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1375260212-19351-1-git-send-email-laura.vasilescu@rosedu.org>
[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]
On Wed, 2013-07-31 at 11:43 +0300, Laura Mihaela Vasilescu wrote:
> Signed-off-by: Laura Mihaela Vasilescu <laura.vasilescu@rosedu.org>
> ---
> drivers/net/ethernet/intel/igb/igb.h | 2 ++
> drivers/net/ethernet/intel/igb/igb_main.c | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
Not sure if I mentioned it in your first submission, if I did not then
my bad. The title of your patch is descriptive of the changes, but it is
always nice to have a detailed patch description. I noticed your second
patch is similar to the first, in that it does not have a detailed patch
description.
Information that would be good to include in the patch description is:
- why the change or reason for the change
- advantages/disadvantages to the change
Laura please re-submit your two patches with a detailed/meaningful patch
description to at least the second patch (but both would be great).
Think of it this way, if someone were to look at your changes 10 years
from now and did not understand why the change, your patch description
would explain all.
Cheers,
Jeff
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-31 9:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 8:43 [PATCH 1/2] igb: Add macro for size of RETA indirection table Laura Mihaela Vasilescu
2013-07-31 8:43 ` [PATCH 2/2] igb: Expose RSS indirection table for ethtool Laura Mihaela Vasilescu
2013-07-31 9:15 ` Jeff Kirsher
2013-08-02 11:52 ` Ben Hutchings
2013-07-31 9:14 ` Jeff Kirsher [this message]
2013-07-31 11:50 ` [PATCH 1/2] igb: Add macro for size of RETA indirection table Laura Mihaela Vasilescu
2013-07-31 12:11 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375262094.2877.31.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=anjali.singhai@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=laura.vasilescu@rosedu.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).