From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Laura Mihaela Vasilescu <laura.vasilescu@rosedu.org>
Cc: netdev@vger.kernel.org, carolyn.wyborny@intel.com,
anjali.singhai@intel.com, alexander.h.duyck@intel.com
Subject: Re: [PATCH 1/2] igb: Add macro for size of RETA indirection table
Date: Wed, 31 Jul 2013 05:11:29 -0700 [thread overview]
Message-ID: <1375272689.2877.33.camel@jtkirshe-mobl> (raw)
In-Reply-To: <CAJ2H2NxCLhZS=nL9w-nt-WBnCJMZk3HBn-rk76WVBKcPj8JXjw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 623 bytes --]
On Wed, 2013-07-31 at 14:50 +0300, Laura Mihaela Vasilescu wrote:
> On Wed, Jul 31, 2013 at 12:14 PM, Jeff Kirsher
> <jeffrey.t.kirsher@intel.com> wrote:
> > Laura please re-submit your two patches with a detailed/meaningful patch
> > description to at least the second patch (but both would be great).
> >
> > Think of it this way, if someone were to look at your changes 10 years
> > from now and did not understand why the change, your patch description
> > would explain all.
>
> I re-submit the patches. I hope there are OK now.
>
> Thanks for the feedback! :)
> Laura
Much better, thank you Laura.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-07-31 12:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 8:43 [PATCH 1/2] igb: Add macro for size of RETA indirection table Laura Mihaela Vasilescu
2013-07-31 8:43 ` [PATCH 2/2] igb: Expose RSS indirection table for ethtool Laura Mihaela Vasilescu
2013-07-31 9:15 ` Jeff Kirsher
2013-08-02 11:52 ` Ben Hutchings
2013-07-31 9:14 ` [PATCH 1/2] igb: Add macro for size of RETA indirection table Jeff Kirsher
2013-07-31 11:50 ` Laura Mihaela Vasilescu
2013-07-31 12:11 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375272689.2877.33.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=anjali.singhai@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=laura.vasilescu@rosedu.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox