From: Joe Perches <joe@perches.com>
To: David Howells <dhowells@redhat.com>
Cc: netdev@vger.kernel.org, linux-hams@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-afs@lists.infradead.org
Subject: Re: [PATCH 0/8] include/net: next set of extern removals
Date: Thu, 01 Aug 2013 09:29:20 -0700 [thread overview]
Message-ID: <1375374560.2034.52.camel@joe-AO722> (raw)
In-Reply-To: <24958.1375358650@warthog.procyon.org.uk>
On Thu, 2013-08-01 at 13:04 +0100, David Howells wrote:
> Joe Perches <joe@perches.com> wrote:
> > Standardize on no extern use on function prototypes
> Can we please standardise on _having_ externs on function prototypes?
Why?
What value is there in using extern for function prototypes?
Your argument for "picking out at a glance"
https://lkml.org/lkml/2013/8/1/237
really doesn't make sense to me.
Basically, anything with parentheses that's not a #define
is an extern.
Exceptions exist for extern function pointers, but those
are fairly unusual anyway. Outside of netfilter,
extern function pointers are only used about a dozen times
total in the kernel tree.
So, please provide some examples supporting your view.
next prev parent reply other threads:[~2013-08-01 16:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 0:31 [PATCH 0/8] include/net: next set of extern removals Joe Perches
2013-08-01 0:31 ` [PATCH 1/8] addrconf.h: Remove extern function prototypes Joe Perches
2013-08-01 0:31 ` [PATCH 2/8] af_unix.h: Remove extern from " Joe Perches
2013-08-01 0:31 ` [PATCH 3/8] af_rxrpc.h: " Joe Perches
2013-08-01 0:31 ` [PATCH 4/8] arp/neighbour.h: " Joe Perches
2013-08-01 0:31 ` [PATCH 5/8] ax25.h: " Joe Perches
2013-08-01 0:31 ` [PATCH 6/8] cfg80211.h/mac80211.h: " Joe Perches
2013-08-01 0:31 ` [PATCH 7/8] checksum: " Joe Perches
2013-08-01 0:31 ` [PATCH 8/8] cls_cgroup.h netprio_cgroup.h: " Joe Perches
2013-08-01 0:50 ` [PATCH 0/8] include/net: next set of extern removals David Miller
2013-08-01 0:58 ` Joe Perches
2013-08-01 12:04 ` David Howells
2013-08-01 16:29 ` Joe Perches [this message]
2013-08-01 16:44 ` Eric Dumazet
2013-08-01 17:05 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375374560.2034.52.camel@joe-AO722 \
--to=joe@perches.com \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).