From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: nikolay@redhat.com, netdev@vger.kernel.org, andy@greyhouse.net,
fubar@us.ibm.com
Subject: Re: [PATCH net] bonding: fix arp monitoring with vlan slaves
Date: Fri, 02 Aug 2013 16:17:46 -0700 [thread overview]
Message-ID: <1375485466.4457.4.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130802.153212.1340051334413929810.davem@davemloft.net>
On Fri, 2013-08-02 at 15:32 -0700, David Miller wrote:
> Handling this specially in bonding isn't really ideal.
>
> Please either hide this detail in dev_trans_start(), or (preferrably)
> have vlan_dev_hard_start_xmit() set the trans_start timestamp
> properly thus making this just work for everything.
vlan is LLTX, so setting the timestamp would incur false sharing on
multiqueue.
But it's true we need a helper, because many callers do
if (dev->priv_flags & IFF_802_1Q_VLAN)
dev = vlan_dev_real_dev(dev);
or the slighly better
if (is_vlan_dev(dev))
dev = vlan_dev_real_dev(dev);
next prev parent reply other threads:[~2013-08-02 23:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 16:41 [PATCH net] bonding: fix arp monitoring with vlan slaves Nikolay Aleksandrov
2013-08-02 22:32 ` David Miller
2013-08-02 22:40 ` Nikolay Aleksandrov
2013-08-02 23:17 ` Eric Dumazet [this message]
2013-08-02 23:29 ` Nikolay Aleksandrov
2013-08-02 23:59 ` Jay Vosburgh
2013-08-03 0:03 ` Eric Dumazet
2013-08-03 0:21 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375485466.4457.4.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox