From: Johannes Berg <johannes@sipsolutions.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Kinley Dorji <kinleyd@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org
Subject: Re: Bug: alx: Atheros AR8131/AR8151/AR8152/AR8161 Ethernet driver
Date: Tue, 06 Aug 2013 13:32:38 +0200 [thread overview]
Message-ID: <1375788758.8219.13.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1375785799.4457.81.camel@edumazet-glaptop> (sfid-20130806_124324_003243_F85A36DB)
On Tue, 2013-08-06 at 03:43 -0700, Eric Dumazet wrote:
> > $ ethtool -S eth0
> > no stats available
>
> It seems alx driver does not support stats.
>
> (No ndo_get_stats() and no changes on netdev->stats embedded stats)
>
>
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c provides
> atl1c_get_stats() gathering hardware counters
>
> CC Johannes Berg, let see if he has plan to add them on alx
I don't. There are some stats in the original code at
https://github.com/erikarn/alx, but I removed them because I didn't
really understand what was going on and don't really care much for the
stats in the system I'm using this device on - and based on the driver
I'm not sure I'd use the chip for 'serious' work anyway :)
FWIW, it had ndo_get_stats() but was updating the netdev->stats from
that handler and then returning them, which seemed a bit questionable.
johannes
next prev parent reply other threads:[~2013-08-06 11:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 5:31 Bug: alx: Atheros AR8131/AR8151/AR8152/AR8161 Ethernet driver Kinley Dorji
2013-08-06 5:57 ` Stephen Hemminger
2013-08-06 6:05 ` Kinley Dorji
2013-08-06 10:43 ` Eric Dumazet
2013-08-06 11:32 ` Johannes Berg [this message]
2013-08-06 12:07 ` Eric Dumazet
2013-08-07 6:32 ` Kinley Dorji
2014-01-08 22:53 ` Sam
2013-08-06 6:23 ` Kinley Dorji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375788758.8219.13.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=eric.dumazet@gmail.com \
--cc=kinleyd@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).