From: Stefan Assmann <sassmann@kpanic.de>
To: netdev@vger.kernel.org
Cc: e1000-devel@lists.sourceforge.net, davem@davemloft.net,
alexander.h.duyck@intel.com, carolyn.wyborny@intel.com,
jeffrey.t.kirsher@intel.com, gregory.v.rose@intel.com,
sassmann@kpanic.de
Subject: [PATCH net-next] igbvf: do not force carrier off in igbvf_msix_other()
Date: Thu, 8 Aug 2013 13:56:42 +0200 [thread overview]
Message-ID: <1375963002-1624-1-git-send-email-sassmann@kpanic.de> (raw)
Currently carrier is forced off in igbvf_msix_other(). This seems
unnecessary and causes multiple calls to igbvf_watchdog_task(), resulting
in multiple link up messages when calling dhclient for example.
[ 111.818106] igbvf 0000:00:04.0: Link is Up 1000 Mbps Full Duplex
[ 111.819347] IPv6: ADDRCONF(NETDEV_UP): eth5: link is not ready
[ 111.820509] IPv6: ADDRCONF(NETDEV_CHANGE): eth5: link becomes ready
[ 111.822983] igbvf 0000:00:04.0: Link is Up 1000 Mbps Full Duplex
[ 115.152421] igbvf 0000:00:04.0: Link is Up 1000 Mbps Full Duplex
compared to
[ 1040.422161] igbvf 0000:00:04.0: Link is Up 1000 Mbps Full Duplex
[ 1040.423447] IPv6: ADDRCONF(NETDEV_UP): eth5: link is not ready
[ 1040.424622] IPv6: ADDRCONF(NETDEV_CHANGE): eth5: link becomes ready
when this patch is applied.
Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
---
drivers/net/ethernet/intel/igbvf/netdev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c
index 93eb7ee..f041586 100644
--- a/drivers/net/ethernet/intel/igbvf/netdev.c
+++ b/drivers/net/ethernet/intel/igbvf/netdev.c
@@ -876,8 +876,6 @@ static irqreturn_t igbvf_msix_other(int irq, void *data)
adapter->int_counter1++;
- netif_carrier_off(netdev);
- hw->mac.get_link_status = 1;
if (!test_bit(__IGBVF_DOWN, &adapter->state))
mod_timer(&adapter->watchdog_timer, jiffies + 1);
--
1.8.3.1
next reply other threads:[~2013-08-08 11:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 11:56 Stefan Assmann [this message]
2013-08-08 16:09 ` [PATCH net-next] igbvf: do not force carrier off in igbvf_msix_other() Alexander Duyck
2013-08-09 7:02 ` Stefan Assmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375963002-1624-1-git-send-email-sassmann@kpanic.de \
--to=sassmann@kpanic.de \
--cc=alexander.h.duyck@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).