Re: [PATCH ethtool]: Add strings to display Supported Ports for Backplane Ethernet

[Ben Hutchings <bhutchings@solarflare.com>]

On Thu, 2013-08-01 at 17:39 +0530, Somnath Kotur wrote:
> Signed-off-by: Somnath Kotur <somnath.kotur@emulex.com>
> ---
>  ethtool.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/ethtool.c b/ethtool.c
> index 3544f0e..b24b572 100644
> --- a/ethtool.c
> +++ b/ethtool.c
> @@ -485,6 +485,9 @@ static void dump_supported(struct ethtool_cmd *ep)
>  		fprintf(stdout, "MII ");
>  	if (mask & SUPPORTED_FIBRE)
>  		fprintf(stdout, "FIBRE ");
> +	if ((mask & SUPPORTED_10000baseKR_Full) ||
> +	    (mask & SUPPORTED_10000baseKX4_Full))
> +		fprintf(stdout, "BACKPLANE ");
>  	fprintf(stdout, "]\n");
>  
>  	dump_link_caps("Supported", "Supports", mask, 0);

No, I don't think so.  This is redundant information.  It's also
pointless to add any new port types to the advertised and supported
masks unless we have hardware that can switch port type at run-time like
some old 10M boards.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.