From: Joe Perches <joe@perches.com>
To: Lutz Jaenicke <ljaenicke@innominate.com>
Cc: netdev@vger.kernel.org,
Claudiu Manoil <claudiu.manoil@freescale.com>,
Ben Hutchings <bhutchings@solarflare.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] gianfar: add support for LFC (Lossless Flow Control)
Date: Fri, 09 Aug 2013 01:39:06 -0700 [thread overview]
Message-ID: <1376037546.2087.69.camel@joe-AO722> (raw)
In-Reply-To: <1376036790-18238-3-git-send-email-ljaenicke@innominate.com>
On Fri, 2013-08-09 at 10:26 +0200, Lutz Jaenicke wrote:
> Implement Lossless Flow Control (let the MAC automatically generate
> PAUSE frames in case of too much incoming traffic.
> Selection of this feature is performed via device tree parameter.
> The board (and processor) specific device tree is authoritative wrt this
> information.
Just a trivial note:
> diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
[]
> @@ -169,10 +169,12 @@ static void gfar_init_rxbdp(struct gfar_priv_rx_q *rx_queue, struct rxbd8 *bdp,
[]
> + u32 *rfbptr;
[]
> @@ -222,6 +225,11 @@ static int gfar_init_bds(struct net_device *ndev)
[]
> + if (priv->device_flags & FSL_GIANFAR_DEV_HAS_LFC)
> + rx_queue->rfbptr = rfbptr;
> + else
> + rx_queue->rfbptr = 0;
s/0/NULL/
next prev parent reply other threads:[~2013-08-09 8:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 10:24 [PATCH 1/2][net-next] gianfar: Fix pause frame handling for half duplex links Claudiu Manoil
2013-08-07 10:24 ` [PATCH 2/2][net-next] gianfar: Add ethtool -A support for pause frame Claudiu Manoil
2013-08-07 19:12 ` Ben Hutchings
2013-08-08 17:10 ` Claudiu Manoil
2013-08-08 18:45 ` Ben Hutchings
2013-08-09 8:26 ` Lutz Jaenicke
2013-08-09 8:26 ` [PATCH] gianfar: implement flow control handling Lutz Jaenicke
2013-08-09 17:19 ` [PATCH][net-next v1] gianfar: Add flow control support Claudiu Manoil
2013-08-09 17:36 ` Fabio Estevam
2013-08-12 7:09 ` Claudiu Manoil
2013-08-09 19:09 ` Joe Perches
2013-08-12 7:08 ` Claudiu Manoil
2013-08-12 10:53 ` [PATCH][net-next v2] " Claudiu Manoil
2013-08-13 22:29 ` David Miller
2013-08-09 8:26 ` [PATCH] gianfar: add support for LFC (Lossless Flow Control) Lutz Jaenicke
2013-08-09 8:39 ` Joe Perches [this message]
2013-08-09 10:12 ` [PATCH 2/2][net-next] gianfar: Add ethtool -A support for pause frame Claudiu Manoil
2013-08-09 10:15 ` Lutz Jaenicke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376037546.2087.69.camel@joe-AO722 \
--to=joe@perches.com \
--cc=bhutchings@solarflare.com \
--cc=claudiu.manoil@freescale.com \
--cc=davem@davemloft.net \
--cc=ljaenicke@innominate.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox