From: Eric Dumazet <eric.dumazet@gmail.com>
To: vyasevic@redhat.com
Cc: Thomas Huth <thuth@linux.vnet.ibm.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] macvtap: fix two races
Date: Fri, 09 Aug 2013 10:41:07 -0700 [thread overview]
Message-ID: <1376070067.20509.1.camel@edumazet-glaptop> (raw)
In-Reply-To: <520523DA.1000400@redhat.com>
On Fri, 2013-08-09 at 13:16 -0400, Vlad Yasevich wrote:
> I was looking at this a bit more and I think this call to
> macvlan_count_rx() is double counting the packets.
>
> In macvlan_handle_frame(), we call macvlan_count_rx() after we call
> vlan->receive(). For macvtap, receive() function is essentially
> macvtap_forward() which just tacks the data onto the queue.
>
> Then, the above code counts the data again as we pull it off the queue
> socket queue to give to the user.
Hmm, it seems a different issue, and probably needs a patch on its own.
When was this problem added ?
next prev parent reply other threads:[~2013-08-09 17:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 14:43 macvtap bug: using smp_processor_id() in preemptible code Thomas Huth
2013-08-07 15:26 ` Eric Dumazet
2013-08-08 8:25 ` Thomas Huth
2013-08-08 13:21 ` Eric Dumazet
2013-08-08 13:56 ` Thomas Huth
2013-08-08 14:04 ` Eric Dumazet
2013-08-08 15:06 ` [PATCH] macvtap: fix two races Eric Dumazet
2013-08-09 17:16 ` Vlad Yasevich
2013-08-09 17:41 ` Eric Dumazet [this message]
2013-08-09 18:01 ` Vlad Yasevich
2013-08-12 4:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376070067.20509.1.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=thuth@linux.vnet.ibm.com \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox