From: Joe Perches <joe@perches.com>
To: Neel Patel <neepatel@cisco.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] drivers/net: enic: Adding support for Cisco Low Latency NIC
Date: Fri, 09 Aug 2013 11:45:39 -0700 [thread overview]
Message-ID: <1376073939.2087.146.camel@joe-AO722> (raw)
In-Reply-To: <1376073535-17154-2-git-send-email-neepatel@cisco.com>
On Fri, 2013-08-09 at 11:38 -0700, Neel Patel wrote:
> diff --git a/drivers/net/ethernet/cisco/enic/vnic_rq.c b/drivers/net/ethernet/cisco/enic/vnic_rq.c
> @@ -30,16 +30,15 @@
> static int vnic_rq_alloc_bufs(struct vnic_rq *rq)
[]
> rq->bufs[i] = kzalloc(VNIC_RQ_BUF_BLK_SZ(count), GFP_ATOMIC);
> - if (!rq->bufs[i])
> + if (!rq->bufs[i]) {
> + pr_err("Failed to alloc rq_bufs\n");
Please don't add OOM messages.
A generic dump_stack() showing the location is
already done by the mm subsystem.
next prev parent reply other threads:[~2013-08-09 18:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 18:38 [PATCH 0/4] enic: This patchset adds support for Cisco Low Latency NIC Neel Patel
2013-08-09 18:38 ` [PATCH 1/4] drivers/net: enic: Adding " Neel Patel
2013-08-09 18:45 ` Joe Perches [this message]
2013-08-09 22:00 ` [PATCH 1/4 v2] " Neel Patel
2013-08-10 0:51 ` David Miller
2013-08-09 18:38 ` [PATCH 2/4] drivers/net: enic: Add an interface for USNIC to interact with firmware Neel Patel
2013-08-09 18:38 ` [PATCH 3/4] drivers/net: enic: Make ASIC information available to USNIC Neel Patel
2013-08-09 18:38 ` [PATCH 4/4] drivers/net: enic: Generate notification of hardware crash Neel Patel
-- strict thread matches above, loose matches on Subject: below --
2013-08-09 18:12 [PATCH 0/4] enic: This patchset adds support for Cisco Low Latency NIC Neel Patel
2013-08-09 18:12 ` [PATCH 1/4] drivers/net: enic: Adding " Neel Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376073939.2087.146.camel@joe-AO722 \
--to=joe@perches.com \
--cc=neepatel@cisco.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox