From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: cooldavid@cooldavid.org, netdev@vger.kernel.org
Subject: Re: question about drivers/net/ethernet/jme.{c,h}
Date: Tue, 13 Aug 2013 10:26:24 -0700 [thread overview]
Message-ID: <1376414784.1949.39.camel@joe-AO722> (raw)
In-Reply-To: <alpine.DEB.2.02.1308131831250.2263@hadrien>
On Tue, 2013-08-13 at 18:33 +0200, Julia Lawall wrote:
> I wonder what is the point of the macro NETIF_NAPI_SET?
Today it seems pretty clear it's useless indirection.
It might have been useful sometime before the jme.c
file was first submitted, but now it should be removed.
In the jme.h file on JMicron's website, the driver
still supports linux versions less than 2.6.23 and
uses a form like this:
ftp://driver.jmicron.com.tw/Ethernet/Linux/jmebp-1.0.8.5.tar.bz
#if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,23)
#define NETIF_NAPI_SET(dev, napis, pollfn, q) \
dev->poll = pollfn; \
dev->weight = q;
#else
#define NETIF_NAPI_SET(dev, napis, pollfn, q) \
netif_napi_add(dev, napis, pollfn, q);
prev parent reply other threads:[~2013-08-13 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 16:33 question about drivers/net/ethernet/jme.{c,h} Julia Lawall
2013-08-13 17:26 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376414784.1949.39.camel@joe-AO722 \
--to=joe@perches.com \
--cc=cooldavid@cooldavid.org \
--cc=julia.lawall@lip6.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox