netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 5/6] vhost_net: poll vhost queue after marking DMA is done
Date: Fri, 16 Aug 2013 13:16:29 +0800	[thread overview]
Message-ID: <1376630190-5912-6-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1376630190-5912-1-git-send-email-jasowang@redhat.com>

We used to poll vhost queue before making DMA is done, this is racy if vhost
thread were waked up before marking DMA is done which can result the signal to
be missed. Fix this by always poll the vhost thread before DMA is done.

Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 drivers/vhost/net.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
index 70cab75..a035a89 100644
--- a/drivers/vhost/net.c
+++ b/drivers/vhost/net.c
@@ -308,6 +308,11 @@ static void vhost_zerocopy_callback(struct ubuf_info *ubuf, bool success)
 	struct vhost_virtqueue *vq = ubufs->vq;
 	int cnt = atomic_read(&ubufs->kref.refcount);
 
+	/* set len to mark this desc buffers done DMA */
+	vq->heads[ubuf->desc].len = success ?
+		VHOST_DMA_DONE_LEN : VHOST_DMA_FAILED_LEN;
+	vhost_net_ubuf_put(ubufs);
+
 	/*
 	 * Trigger polling thread if guest stopped submitting new buffers:
 	 * in this case, the refcount after decrement will eventually reach 1
@@ -318,10 +323,6 @@ static void vhost_zerocopy_callback(struct ubuf_info *ubuf, bool success)
 	 */
 	if (cnt <= 2 || !(cnt % 16))
 		vhost_poll_queue(&vq->poll);
-	/* set len to mark this desc buffers done DMA */
-	vq->heads[ubuf->desc].len = success ?
-		VHOST_DMA_DONE_LEN : VHOST_DMA_FAILED_LEN;
-	vhost_net_ubuf_put(ubufs);
 }
 
 /* Expects to be always run from workqueue - which acts as
-- 
1.7.1

  parent reply	other threads:[~2013-08-16  5:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-16  5:16 [PATCH 0/6] vhost code cleanup and minor enhancement Jason Wang
2013-08-16  5:16 ` [PATCH 1/6] vhost_net: make vhost_zerocopy_signal_used() returns void Jason Wang
2013-08-16  5:16 ` [PATCH 2/6] vhost_net: use vhost_add_used_and_signal_n() in vhost_zerocopy_signal_used() Jason Wang
2013-08-16  9:54   ` Michael S. Tsirkin
2013-08-20  2:33     ` Jason Wang
2013-08-23  8:50       ` Jason Wang
2013-08-25 11:48         ` Michael S. Tsirkin
2013-08-16  5:16 ` [PATCH 3/6] vhost: switch to use vhost_add_used_n() Jason Wang
2013-08-16  9:56   ` Michael S. Tsirkin
2013-08-20  2:36     ` Jason Wang
2013-08-16  5:16 ` [PATCH 4/6] vhost_net: determine whether or not to use zerocopy at one time Jason Wang
2013-08-16  5:16 ` Jason Wang [this message]
2013-08-16 10:00   ` [PATCH 5/6] vhost_net: poll vhost queue after marking DMA is done Michael S. Tsirkin
2013-08-20  2:44     ` Jason Wang
2013-08-16  5:16 ` [PATCH 6/6] vhost_net: remove the max pending check Jason Wang
2013-08-16 10:02   ` Michael S. Tsirkin
2013-08-20  2:48     ` Jason Wang
2013-08-23  8:55       ` Jason Wang
2013-08-25 11:53         ` Michael S. Tsirkin
2013-08-26  7:00           ` Jason Wang
2013-08-30  3:23           ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376630190-5912-6-git-send-email-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).