From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 6/6] vhost_net: remove the max pending check
Date: Fri, 16 Aug 2013 13:16:30 +0800 [thread overview]
Message-ID: <1376630190-5912-7-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1376630190-5912-1-git-send-email-jasowang@redhat.com>
We used to limit the max pending DMAs to prevent guest from pinning too many
pages. But this could be removed since:
- We have the sk_wmem_alloc check in both tun/macvtap to do the same work
- This max pending check were almost useless since it was one done when there's
no new buffers coming from guest. Guest can easily exceeds the limitation.
- We've already check upend_idx != done_idx and switch to non zerocopy then. So
even if all vq->heads were used, we can still does the packet transmission.
So remove this check completely.
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/vhost/net.c | 13 -------------
1 files changed, 0 insertions(+), 13 deletions(-)
diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
index a035a89..ed3f165 100644
--- a/drivers/vhost/net.c
+++ b/drivers/vhost/net.c
@@ -38,8 +38,6 @@ MODULE_PARM_DESC(experimental_zcopytx, "Enable Zero Copy TX;"
* Using this limit prevents one virtqueue from starving others. */
#define VHOST_NET_WEIGHT 0x80000
-/* MAX number of TX used buffers for outstanding zerocopy */
-#define VHOST_MAX_PEND 128
#define VHOST_GOODCOPY_LEN 256
/*
@@ -372,17 +370,6 @@ static void handle_tx(struct vhost_net *net)
break;
/* Nothing new? Wait for eventfd to tell us they refilled. */
if (head == vq->num) {
- int num_pends;
-
- /* If more outstanding DMAs, queue the work.
- * Handle upend_idx wrap around
- */
- num_pends = likely(nvq->upend_idx >= nvq->done_idx) ?
- (nvq->upend_idx - nvq->done_idx) :
- (nvq->upend_idx + UIO_MAXIOV -
- nvq->done_idx);
- if (unlikely(num_pends > VHOST_MAX_PEND))
- break;
if (unlikely(vhost_enable_notify(&net->dev, vq))) {
vhost_disable_notify(&net->dev, vq);
continue;
--
1.7.1
next prev parent reply other threads:[~2013-08-16 5:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 5:16 [PATCH 0/6] vhost code cleanup and minor enhancement Jason Wang
2013-08-16 5:16 ` [PATCH 1/6] vhost_net: make vhost_zerocopy_signal_used() returns void Jason Wang
2013-08-16 5:16 ` [PATCH 2/6] vhost_net: use vhost_add_used_and_signal_n() in vhost_zerocopy_signal_used() Jason Wang
2013-08-16 9:54 ` Michael S. Tsirkin
2013-08-20 2:33 ` Jason Wang
2013-08-23 8:50 ` Jason Wang
2013-08-25 11:48 ` Michael S. Tsirkin
2013-08-16 5:16 ` [PATCH 3/6] vhost: switch to use vhost_add_used_n() Jason Wang
2013-08-16 9:56 ` Michael S. Tsirkin
2013-08-20 2:36 ` Jason Wang
2013-08-16 5:16 ` [PATCH 4/6] vhost_net: determine whether or not to use zerocopy at one time Jason Wang
2013-08-16 5:16 ` [PATCH 5/6] vhost_net: poll vhost queue after marking DMA is done Jason Wang
2013-08-16 10:00 ` Michael S. Tsirkin
2013-08-20 2:44 ` Jason Wang
2013-08-16 5:16 ` Jason Wang [this message]
2013-08-16 10:02 ` [PATCH 6/6] vhost_net: remove the max pending check Michael S. Tsirkin
2013-08-20 2:48 ` Jason Wang
2013-08-23 8:55 ` Jason Wang
2013-08-25 11:53 ` Michael S. Tsirkin
2013-08-26 7:00 ` Jason Wang
2013-08-30 3:23 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376630190-5912-7-git-send-email-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).