Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: netdev@vger.kernel.org, steffen.klassert@secunet.com,
	edumazet@google.com
Subject: Re: [PATCH ipsec v2 3/3] xfrm: choose protocol family by skb protocol
Date: Sun, 18 Aug 2013 08:48:21 -0700	[thread overview]
Message-ID: <1376840901.21329.47.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130818114701.GA10270@order.stressinduktion.org>

On Sun, 2013-08-18 at 13:47 +0200, Hannes Frederic Sowa wrote:
> We need to choose the protocol family by skb->protocol. Otherwise we
> call the wrong xfrm{4,6}_local_error handler in case an ipv6 sockets is
> used in ipv4 mode, in which case we should call down to xfrm4_local_error
> (ip6 sockets are a superset of ip4 ones).
> 
> We are called before before ip_output functions, so skb->protocol is
> not reset.
> 
> v2:
> a) unchanged
> 
> Cc: Steffen Klassert <steffen.klassert@secunet.com>
> Acked-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> ---

Hi Hannes

For your next patches, please add the v1/v2/v3 stuff _after_ the ---
separator as in :

Normal changelog (will be included in git history)

Signed-off-by: ....
Cc: ...
---
v2: Fix (you can omit this line if there was no change between v2 and
v1)
 diffstat
 diff


This is to have clean changelogs, with high S/N ratio ;)

Thanks !

  reply	other threads:[~2013-08-18 15:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-18 11:47 [PATCH ipsec v2 3/3] xfrm: choose protocol family by skb protocol Hannes Frederic Sowa
2013-08-18 15:48 ` Eric Dumazet [this message]
2013-08-18 16:05   ` Hannes Frederic Sowa
2013-08-19 11:46 ` Steffen Klassert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376840901.21329.47.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=edumazet@google.com \
    --cc=hannes@stressinduktion.org \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox