Re: [ PATCH net-next ] xfrm: remove irrelevant comment in xfrm_input().

Re: [ PATCH net-next ] xfrm: remove irrelevant comment in xfrm_input().

[Steffen Klassert]

On Mon, Aug 19, 2013 at 03:47:11PM +0300, Rami Rosen wrote:
> This patch removes a comment in xfrm_input() which became irrelevant
> due to commit 2774c13, "xfrm: Handle blackhole route creation via afinfo".
> That commit removed returning -EREMOTE in the xfrm_lookup() method when the 
> packet should be discarded  and also removed the correspoinding -EREMOTE 
> handlers. This was replaced by calling the make_blackhole() method. Therefore
> the comment about -EREMOTE is not relevant anymore.
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>

Applied to ipsec-next, thanks!

[ PATCH net-next ] xfrm: remove irrelevant comment in xfrm_input().

[Rami Rosen]

This patch removes a comment in xfrm_input() which became irrelevant
due to commit 2774c13, "xfrm: Handle blackhole route creation via afinfo".
That commit removed returning -EREMOTE in the xfrm_lookup() method when the 
packet should be discarded  and also removed the correspoinding -EREMOTE 
handlers. This was replaced by calling the make_blackhole() method. Therefore
the comment about -EREMOTE is not relevant anymore.

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 net/xfrm/xfrm_policy.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index d8da6b8..3d65c6e 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -2132,8 +2132,6 @@ restart:
 		 * have the xfrm_state's. We need to wait for KM to
 		 * negotiate new SA's or bail out with error.*/
 		if (net->xfrm.sysctl_larval_drop) {
-			/* EREMOTE tells the caller to generate
-			 * a one-shot blackhole route. */
 			dst_release(dst);
 			xfrm_pols_put(pols, drop_pols);
 			XFRM_INC_STATS(net, LINUX_MIB_XFRMOUTNOSTATES);
-- 
1.8.1.4