From: Johannes Berg <johannes@sipsolutions.net>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, amwang@redhat.com, jiri@resnulli.us,
stephen@networkplumber.org, kaber@trash.net, davem@davemloft.net,
vyasevic@redhat.com, eric.dumazet@gmail.com
Subject: Re: [PATCH 1/3] net: add a new NETDEV_CHANGEROOM event type
Date: Tue, 20 Aug 2013 17:16:58 +0200 [thread overview]
Message-ID: <1377011818.13829.9.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1377002752-4622-2-git-send-email-f.fainelli@gmail.com>
On Tue, 2013-08-20 at 13:45 +0100, Florian Fainelli wrote:
> /**
> + * dev_set_headroom - Change device needed headroom
> + * @dev: device
> + * @new_headroom: new headroom size
> + *
> + * Change the network device headroom space.
> + */
> +int dev_set_headroom(struct net_device *dev, unsigned short new_headroom)
It seems that you need to invoke these under RTNL, might be worth
documenting that.
Also, maybe it would be worth doing it in one call? If you need to
change both, then you'd end up calling the notifier twice, which is less
efficient? I suppose you could make them 'int' arguments and reserve -1
for no changes, or just require both new values to be given (if doing
this at all.)
johannes
next prev parent reply other threads:[~2013-08-20 15:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 12:45 [PATCH 0/3] net: propagate dynamic needed_headroom/tailroom changes Florian Fainelli
2013-08-20 12:45 ` [PATCH 1/3] net: add a new NETDEV_CHANGEROOM event type Florian Fainelli
2013-08-20 15:16 ` Johannes Berg [this message]
2013-08-20 15:30 ` Florian Fainelli
2013-08-20 16:10 ` Jiri Pirko
2013-08-20 16:35 ` Johannes Berg
2013-08-20 17:30 ` Florian Fainelli
2013-08-20 12:45 ` [PATCH 2/3] net: vlan: handle NETDEV_CHANGEROOM events Florian Fainelli
2013-08-20 12:45 ` [PATCH 3/3] net: bridge: handle NETDEV_CHANGEROOM event Florian Fainelli
2013-08-20 13:29 ` [PATCH 0/3] net: propagate dynamic needed_headroom/tailroom changes Jiri Pirko
2013-08-20 14:24 ` Florian Fainelli
2013-08-20 14:27 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377011818.13829.9.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).