From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ferry Huberts <mailings@hupie.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 2/2] net: netem: always adjust now/delay when not reordering
Date: Tue, 20 Aug 2013 23:14:07 -0700 [thread overview]
Message-ID: <1377065647.4226.96.camel@edumazet-glaptop> (raw)
In-Reply-To: <1377064785-12629-1-git-send-email-mailings@hupie.com>
On Wed, 2013-08-21 at 07:59 +0200, Ferry Huberts wrote:
> From: Ferry Huberts <ferry.huberts@pelagic.nl>
>
> Not doing this (current behaviour) introduces reordering.
>
> The packet_len_2_sched_time call is the only thing that logically
> depends on q->rate, so move the now/delay adjustment out of the if.
>
> How to test:
> -----------
I ask again :
Did you test a config with both rate limiting and delay.
Netem primary use is to emulate say a 1Mbits link with a rtt of 50ms
netem rate 1Mbit delay 50ms
Because the "delay 10ms 500ms" is very strange : effective delay is in
the following range : -490 ms ... 510 ms
Its probably clamped to 0ms ... 510ms
I really doubt this is what you wanted.
next prev parent reply other threads:[~2013-08-21 6:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 15:11 [PATCH 1/2] net: netem: do not reorder when reordering is disabled Ferry Huberts
2013-08-20 15:11 ` [PATCH 2/2] net: netem: always adjust now/delay when not reordering Ferry Huberts
2013-08-20 18:31 ` Sergei Shtylyov
2013-08-20 20:33 ` Eric Dumazet
2013-08-21 5:59 ` [PATCH v2 " Ferry Huberts
2013-08-21 6:14 ` Eric Dumazet [this message]
2013-08-21 7:04 ` Ferry Huberts
2013-08-21 13:30 ` Eric Dumazet
2013-08-21 14:02 ` mailings
2013-08-21 14:10 ` mailings
2013-08-21 15:17 ` [PATCH " Johannes Naab
2013-08-21 15:39 ` Eric Dumazet
2013-08-21 16:14 ` Ferry Huberts
2013-08-21 17:00 ` Eric Dumazet
2013-08-21 17:35 ` Stephen Hemminger
2013-08-23 12:50 ` Ferry Huberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377065647.4226.96.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=mailings@hupie.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox