From: Libo Chen <libo.chen@huawei.com>
To: <davem@davemloft.net>
Cc: <michal.simek@xilinx.com>, <renner@efe-gmbh.de>,
<gregkh@linuxfoundation.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <lizefan@huawei.com>,
<libo.chen@huawei.com>
Subject: [PATCH 6/8] net: xilinx_emaclite: remove unnecessary dev_set_drvdata()
Date: Wed, 21 Aug 2013 15:02:36 +0800 [thread overview]
Message-ID: <1377068556-51316-1-git-send-email-libo.chen@huawei.com> (raw)
Unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/net/ethernet/xilinx/xilinx_emaclite.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
index 7c1ccbc..4c619ea 100644
--- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
+++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
@@ -1249,7 +1249,6 @@ static int xemaclite_of_remove(struct platform_device *of_dev)
lp->phy_node = NULL;
xemaclite_remove_ndev(ndev, of_dev);
- dev_set_drvdata(dev, NULL);
return 0;
}
--
1.7.1
next reply other threads:[~2013-08-21 7:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 7:02 Libo Chen [this message]
2013-08-21 7:21 ` [PATCH 6/8] net: xilinx_emaclite: remove unnecessary dev_set_drvdata() Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377068556-51316-1-git-send-email-libo.chen@huawei.com \
--to=libo.chen@huawei.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=renner@efe-gmbh.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).