* [PATCH 7/8] net: davinci_mdio: remove unnecessary dev_set_drvdata()
@ 2013-08-21 7:02 Libo Chen
2013-08-22 5:53 ` Prabhakar Lad
0 siblings, 1 reply; 2+ messages in thread
From: Libo Chen @ 2013-08-21 7:02 UTC (permalink / raw)
To: davem
Cc: mugunthanvnm, bigeasy, prabhakar.csengg, netdev, linux-kernel,
lizefan, libo.chen
Unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/net/ethernet/ti/davinci_mdio.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
index 01b0cc5..7f85143 100644
--- a/drivers/net/ethernet/ti/davinci_mdio.c
+++ b/drivers/net/ethernet/ti/davinci_mdio.c
@@ -433,8 +433,6 @@ static int davinci_mdio_remove(struct platform_device *pdev)
pm_runtime_put_sync(&pdev->dev);
pm_runtime_disable(&pdev->dev);
- dev_set_drvdata(dev, NULL);
-
kfree(data);
return 0;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 7/8] net: davinci_mdio: remove unnecessary dev_set_drvdata()
2013-08-21 7:02 [PATCH 7/8] net: davinci_mdio: remove unnecessary dev_set_drvdata() Libo Chen
@ 2013-08-22 5:53 ` Prabhakar Lad
0 siblings, 0 replies; 2+ messages in thread
From: Prabhakar Lad @ 2013-08-22 5:53 UTC (permalink / raw)
To: Libo Chen; +Cc: David S. Miller, Mugunthan V N, bigeasy, netdev, LKML, Li Zefan
Hi Libo,
Thanks for the patch.
On Wed, Aug 21, 2013 at 12:32 PM, Libo Chen <libo.chen@huawei.com> wrote:
> Unnecessary dev_set_drvdata() is removed, because the driver core
> clears the driver data to NULL after device_release or on probe failure.
>
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Regards,
--Prabhakar Lad
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-22 5:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-21 7:02 [PATCH 7/8] net: davinci_mdio: remove unnecessary dev_set_drvdata() Libo Chen
2013-08-22 5:53 ` Prabhakar Lad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).