* [PATCH 1/2] hso: Earlier catch of error condition
@ 2013-08-21 8:43 Daniel Gimpelevich
2013-08-21 16:25 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Gimpelevich @ 2013-08-21 8:43 UTC (permalink / raw)
To: gregkh, j.dumon, linux-usb, netdev, linux-kernel
There is no need to get an interface specification if we know it's the
wrong one.
Signed-off-by: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>
---
drivers/net/usb/hso.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index cba1d46..5fb36ed 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -2886,6 +2886,11 @@ static int hso_probe(struct usb_interface *interface,
struct hso_shared_int *shared_int;
struct hso_device *tmp_dev = NULL;
+ if (interface->cur_altsetting->desc.bInterfaceClass != 0xFF) {
+ dev_err(&interface->dev, "Not our interface\n");
+ return -ENODEV;
+ }
+
if_num = interface->altsetting->desc.bInterfaceNumber;
/* Get the interface/port specification from either driver_info or from
@@ -2895,10 +2900,6 @@ static int hso_probe(struct usb_interface *interface,
else
port_spec = hso_get_config_data(interface);
- if (interface->cur_altsetting->desc.bInterfaceClass != 0xFF) {
- dev_err(&interface->dev, "Not our interface\n");
- return -ENODEV;
- }
/* Check if we need to switch to alt interfaces prior to port
* configuration */
if (interface->num_altsetting > 1)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] hso: Earlier catch of error condition
2013-08-21 8:43 [PATCH 1/2] hso: Earlier catch of error condition Daniel Gimpelevich
@ 2013-08-21 16:25 ` Greg KH
2013-08-22 3:48 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2013-08-21 16:25 UTC (permalink / raw)
To: Daniel Gimpelevich; +Cc: j.dumon, linux-usb, netdev, linux-kernel
On Wed, Aug 21, 2013 at 01:43:07AM -0700, Daniel Gimpelevich wrote:
> There is no need to get an interface specification if we know it's the
> wrong one.
>
> Signed-off-by: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] hso: Earlier catch of error condition
2013-08-21 16:25 ` Greg KH
@ 2013-08-22 3:48 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-08-22 3:48 UTC (permalink / raw)
To: gregkh; +Cc: daniel, j.dumon, linux-usb, netdev, linux-kernel
From: Greg KH <gregkh@linuxfoundation.org>
Date: Wed, 21 Aug 2013 09:25:07 -0700
> On Wed, Aug 21, 2013 at 01:43:07AM -0700, Daniel Gimpelevich wrote:
>> There is no need to get an interface specification if we know it's the
>> wrong one.
>>
>> Signed-off-by: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-22 3:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-21 8:43 [PATCH 1/2] hso: Earlier catch of error condition Daniel Gimpelevich
2013-08-21 16:25 ` Greg KH
2013-08-22 3:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox