From: Johannes Berg <johannes@sipsolutions.net>
To: Pravin B Shelar <pshelar@nicira.com>
Cc: netdev@vger.kernel.org, Jesse Gross <jesse@nicira.com>
Subject: Re: [PATCH 1/2] genl: Fix genl dumpit() locking.
Date: Thu, 22 Aug 2013 09:36:20 +0200 [thread overview]
Message-ID: <1377156980.14110.16.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1377143882-20717-1-git-send-email-pshelar@nicira.com>
On Wed, 2013-08-21 at 20:58 -0700, Pravin B Shelar wrote:
> In case of genl-family with parallel ops off, dumpif() callback
> is expected to run under genl_lock, But commit def3117493eafd9df
> (genl: Allow concurrent genl callbacks.) changed this behaviour
> where only first dumpit() op was called under genl-lock.
> For subsequent dump, only nlk->cb_lock was taken.
> Following patch fixes it by defining locked dumpit() and done()
> callback which takes care of genl-locking.
As I've commented over in the other thread, I really think this is the
wrong thing to do. It was never the case that dumpit() was actually
locked under genl_lock(), and adding it doesn't really help anyone.
johannes
next prev parent reply other threads:[~2013-08-22 7:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 3:58 [PATCH 1/2] genl: Fix genl dumpit() locking Pravin B Shelar
2013-08-22 7:36 ` Johannes Berg [this message]
2013-08-22 17:42 ` Pravin Shelar
2013-08-22 17:51 ` Johannes Berg
2013-08-22 17:51 ` Johannes Berg
2013-08-22 18:10 ` Pravin Shelar
2013-08-22 18:18 ` Johannes Berg
2013-08-22 20:31 ` Pravin Shelar
2013-08-23 7:29 ` Johannes Berg
2013-08-23 9:51 ` Johannes Berg
2013-08-23 20:52 ` Pravin Shelar
2013-08-26 6:06 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2013-08-22 21:25 Pravin B Shelar
2013-08-23 7:20 ` Johannes Berg
2013-08-23 17:05 ` Pravin Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377156980.14110.16.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).