netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Pravin Shelar <pshelar@nicira.com>
Cc: netdev <netdev@vger.kernel.org>, Jesse Gross <jesse@nicira.com>
Subject: Re: [PATCH 1/2] genl: Fix genl dumpit() locking.
Date: Thu, 22 Aug 2013 20:18:54 +0200	[thread overview]
Message-ID: <1377195534.14110.29.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CALnjE+rEOMmyFQ0Nx3-O-Cvu8yePVBg7x8vgpGUOAAnYv3KG4Q@mail.gmail.com>

On Thu, 2013-08-22 at 11:10 -0700, Pravin Shelar wrote:

> > By the way - why? This just means that netlink will allocate another
> > lock to lock it all, so it's not a very useful change?
> >
> This replaces global genl-lock with per-socket lock which allows
> parallel operation in parallel-genl-families and they are not blocked
> due to other unrelated genl-family operations.

I don't think so? It replaces the genl lock as cb_mutex with a per
*kernel* socket lock, so really just one per network namespace. That's
not much of an improvement really.

johannes

  reply	other threads:[~2013-08-22 18:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-22  3:58 [PATCH 1/2] genl: Fix genl dumpit() locking Pravin B Shelar
2013-08-22  7:36 ` Johannes Berg
2013-08-22 17:42   ` Pravin Shelar
2013-08-22 17:51     ` Johannes Berg
2013-08-22 17:51     ` Johannes Berg
2013-08-22 18:10       ` Pravin Shelar
2013-08-22 18:18         ` Johannes Berg [this message]
2013-08-22 20:31           ` Pravin Shelar
2013-08-23  7:29             ` Johannes Berg
2013-08-23  9:51               ` Johannes Berg
2013-08-23 20:52                 ` Pravin Shelar
2013-08-26  6:06                   ` Johannes Berg
  -- strict thread matches above, loose matches on Subject: below --
2013-08-22 21:25 Pravin B Shelar
2013-08-23  7:20 ` Johannes Berg
2013-08-23 17:05   ` Pravin Shelar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377195534.14110.29.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=jesse@nicira.com \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@nicira.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).