From: Joe Perches <joe@perches.com>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: zambrano@broadcom.com, netdev@vger.kernel.org,
Florian Fainelli <florian@openwrt.org>
Subject: Re: [RFC] b44: use phylib
Date: Fri, 23 Aug 2013 16:10:09 -0700 [thread overview]
Message-ID: <1377299409.2816.19.camel@joe-AO722> (raw)
In-Reply-To: <1377298608-18016-1-git-send-email-hauke@hauke-m.de>
On Sat, 2013-08-24 at 00:56 +0200, Hauke Mehrtens wrote:
> This splits the driver into the mac and a phy driver. On routers where
> this driver is used we have a switch which implements a phy and can be
> controlled by a phy driver.
trivial comments only...
> diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c
[]
> +static void b44_adjust_link(struct net_device *dev)
> +{
> + struct b44 *bp = netdev_priv(dev);
> + struct phy_device *phydev = bp->phydev;
> + int status_changed = 0;
bool?
> +static int b44_mii_probe(struct net_device *dev)
> +{
[]
> + if (IS_ERR(phydev)) {
> + netdev_err(dev, "could not attach PHY: %s", phy_id);
missing newline?
next prev parent reply other threads:[~2013-08-23 23:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 22:56 [RFC] b44: use phylib Hauke Mehrtens
2013-08-23 23:10 ` Joe Perches [this message]
2013-08-24 14:32 ` Hauke Mehrtens
2013-09-18 15:00 ` Hauke Mehrtens
2013-09-18 15:03 ` Hauke Mehrtens
2013-09-18 15:19 ` Joe Perches
2013-09-18 15:29 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377299409.2816.19.camel@joe-AO722 \
--to=joe@perches.com \
--cc=florian@openwrt.org \
--cc=hauke@hauke-m.de \
--cc=netdev@vger.kernel.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).