Re: Do you guys think add link test to offline test is reasonable?

Re: Do you guys think add link test to offline test is reasonable?

[Ben Hutchings]

On Mon, 2013-08-26 at 15:47 +0800, Hui-Zhi Zhao wrote:
> Hi Guys,
> 
> 
> I have a query about the ethtool offline test.
> 
> 
> From the man page of "ethtool" I see the offline test should be
> "offline (default) means to perform full set of tests possibly causing
> normal operation interruption during the tests". In my opinion, it
> should just do something like inner loopback tests, offline should be
> no relative with live network connection.

I agree that an offline test should not depend on having a network link.

> Since it is impractical to expect these ports to be connected to a
> live network during production test (due to  limited network
> resources, a machine maybe have lots of ports), some of the tests will
> fail, even the cards have no problem.
>
> So, do you guys think add link test to offline test is reasonable?

You can do it but it shouldn't affect the overall pass/fail result.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.