From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Don Skidmore <donald.c.skidmore@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 03/10] ixgbe: fix incorrect limit value in ring transverse
Date: Wed, 28 Aug 2013 03:33:41 -0700 [thread overview]
Message-ID: <1377686028-30747-4-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1377686028-30747-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Don Skidmore <donald.c.skidmore@intel.com>
We were transversing the tx_ring with IXGBE_NUM_RX_QUEUES. Now this define
happens to have the correct value but this is misleading and a change later
could easily make this no longer true. I updated it to netdev->num_tx_queues
like we use in ixgbe_get_strings().
Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
index 50c1e9b..db0dbf6 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
@@ -1049,7 +1049,7 @@ static void ixgbe_get_ethtool_stats(struct net_device *netdev,
data[i] = (ixgbe_gstrings_stats[i].sizeof_stat ==
sizeof(u64)) ? *(u64 *)p : *(u32 *)p;
}
- for (j = 0; j < IXGBE_NUM_RX_QUEUES; j++) {
+ for (j = 0; j < netdev->num_tx_queues; j++) {
ring = adapter->tx_ring[j];
if (!ring) {
data[i] = 0;
--
1.8.3.1
next prev parent reply other threads:[~2013-08-28 10:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 10:33 [net-next 00/10][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2013-08-28 10:33 ` [net-next 01/10] ixgbe: disable link when adapter goes down Jeff Kirsher
2013-08-28 10:33 ` [net-next 02/10] ixgbe: Check return value on eeprom reads Jeff Kirsher
2013-08-28 10:33 ` Jeff Kirsher [this message]
2013-08-28 10:33 ` [net-next 04/10] ixgbe: fix link test when connected to 1Gbps link partner Jeff Kirsher
2013-08-28 18:28 ` Sergei Shtylyov
2013-08-28 20:24 ` Tantilov, Emil S
2013-08-28 20:38 ` Sergei Shtylyov
2013-08-28 10:33 ` [net-next 05/10] ixgbe: zero out mailbox buffer on init Jeff Kirsher
2013-08-28 10:33 ` [net-next 06/10] ixgbe: cleanup some log messages Jeff Kirsher
2013-08-28 14:49 ` Joe Perches
2013-08-28 16:19 ` Skidmore, Donald C
2013-08-28 16:36 ` Joe Perches
2013-08-28 10:33 ` [net-next 07/10] ixgbe: fix SFF data dumps of SFP+ modules from an offset Jeff Kirsher
2013-08-29 1:00 ` Ben Hutchings
2013-08-28 10:33 ` [net-next 08/10] ixgbe: add 1Gbps support for QSFP+ Jeff Kirsher
2013-08-28 10:33 ` [net-next 09/10] ixgbe: include QSFP PHY types in ixgbe_is_sfp() Jeff Kirsher
2013-08-28 10:33 ` [net-next 10/10] ixgbe: add support for older QSFP active DA cables Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377686028-30747-4-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=gospo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).