From: Veaceslav Falico <vfalico@redhat.com>
To: netdev@vger.kernel.org
Cc: Veaceslav Falico <vfalico@redhat.com>,
Jay Vosburgh <fubar@us.ibm.com>,
Andy Gospodarek <andy@greyhouse.net>
Subject: [PATCH net-next v2 13/13] bonding: pr_debug instead of pr_warn in bond_arp_send_all
Date: Wed, 28 Aug 2013 14:02:32 +0200 [thread overview]
Message-ID: <1377691352-4146-14-git-send-email-vfalico@redhat.com> (raw)
In-Reply-To: <1377691352-4146-1-git-send-email-vfalico@redhat.com>
They're simply annoying and will spam dmesg constantly if we hit them, so
convert to pr_debug so that we still can access them in case of debugging.
v2: new patch
CC: Jay Vosburgh <fubar@us.ibm.com>
CC: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
---
drivers/net/bonding/bond_main.c | 14 ++++++--------
1 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index a52cff1..47e1052 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -2336,10 +2336,8 @@ static void bond_arp_send_all(struct bonding *bond, struct slave *slave)
rt = ip_route_output(dev_net(bond->dev), targets[i], 0,
RTO_ONLINK, 0);
if (IS_ERR(rt)) {
- if (net_ratelimit()) {
- pr_warning("%s: no route to arp_ip_target %pI4\n",
- bond->dev->name, &targets[i]);
- }
+ pr_debug("%s: no route to arp_ip_target %pI4\n",
+ bond->dev->name, &targets[i]);
continue;
}
@@ -2364,10 +2362,10 @@ static void bond_arp_send_all(struct bonding *bond, struct slave *slave)
rcu_read_unlock();
/* Not our device - skip */
- if (net_ratelimit())
- pr_warning("%s: no path to arp_ip_target %pI4 via rt.dev %s\n",
- bond->dev->name, &targets[i],
- rt->dst.dev ? rt->dst.dev->name : "NULL");
+ pr_debug("%s: no path to arp_ip_target %pI4 via rt.dev %s\n",
+ bond->dev->name, &targets[i],
+ rt->dst.dev ? rt->dst.dev->name : "NULL");
+
ip_rt_put(rt);
continue;
--
1.7.1
next prev parent reply other threads:[~2013-08-28 12:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 12:02 [PATCH net-next v2 0/13] bonding: remove vlan special handling Veaceslav Falico
2013-08-28 12:02 ` [PATCH net-next v2 01/13] net: rename netdev_upper to netdev_adjacent Veaceslav Falico
2013-08-28 12:02 ` [PATCH net-next v2 02/13] net: add lower_dev_list to net_device and make a full mesh Veaceslav Falico
2013-08-28 13:59 ` Jiri Pirko
2013-08-28 14:15 ` Veaceslav Falico
2013-08-28 12:02 ` [PATCH net-next v2 03/13] net: remove search_list from netdev_adjacent Veaceslav Falico
2013-08-28 12:02 ` [PATCH net-next v2 04/13] net: add netdev_upper_get_next_dev_rcu(dev, iter) Veaceslav Falico
2013-08-28 12:02 ` [PATCH net-next v2 05/13] net: add netdev_for_each_upper_dev_rcu() Veaceslav Falico
2013-08-28 12:02 ` [PATCH net-next v2 06/13] bonding: use netdev_upper list in bond_vlan_used Veaceslav Falico
2013-08-28 12:02 ` [PATCH net-next v2 07/13] bonding: make bond_arp_send_all use upper device list Veaceslav Falico
2013-08-28 12:02 ` [PATCH net-next v2 08/13] bonding: convert bond_has_this_ip() to use upper devices Veaceslav Falico
2013-08-28 12:02 ` [PATCH net-next v2 09/13] bonding: use vlan_uses_dev() in __bond_release_one() Veaceslav Falico
2013-08-28 12:02 ` [PATCH net-next v2 10/13] bonding: split alb_send_learning_packets() Veaceslav Falico
2013-08-28 12:02 ` [PATCH net-next v2 11/13] bonding: make alb_send_learning_packets() use upper dev list Veaceslav Falico
2013-08-28 12:02 ` [PATCH net-next v2 12/13] bonding: remove vlan_list/current_alb_vlan Veaceslav Falico
2013-08-28 12:02 ` Veaceslav Falico [this message]
2013-08-28 16:04 ` [PATCH net-next v2 0/13] bonding: remove vlan special handling Veaceslav Falico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377691352-4146-14-git-send-email-vfalico@redhat.com \
--to=vfalico@redhat.com \
--cc=andy@greyhouse.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).