From: Joe Perches <joe@perches.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: liujunliang_ljl@163.com, davem@davemloft.net, horms@verge.net.au,
gregkh@linuxfoundation.org, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
sunhecheng@vip.126.com
Subject: Re: [PATCH] USB2NET : SR9700 : One Chip USB 1.1 USB2NET SR9700 Device Driver Support
Date: Thu, 29 Aug 2013 21:42:41 -0700 [thread overview]
Message-ID: <1377837761.1928.139.camel@joe-AO722> (raw)
In-Reply-To: <20130829230644.GA12124@electric-eye.fr.zoreil.com>
On Fri, 2013-08-30 at 01:06 +0200, Francois Romieu wrote:
just trivia:
> diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c
[]
> @@ -288,19 +291,19 @@ static void sr9700_set_multicast(struct net_device *net)
[]
> +static int sr9700_set_mac_address(struct net_device *netdev, void *p)
[]
> - memcpy(net->dev_addr, addr->sa_data, net->addr_len);
> - sr_write_async(dev, PAR, 6, dev->net->dev_addr);
> + memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
> + sr_write_async(dev, PAR, 6, netdev->dev_addr);
s/6/ETH_ALEN/
next prev parent reply other threads:[~2013-08-30 4:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 3:27 [PATCH] USB2NET : SR9700 : One Chip USB 1.1 USB2NET SR9700 Device Driver Support liujunliang_ljl
2013-08-29 23:06 ` Francois Romieu
2013-08-30 4:42 ` Joe Perches [this message]
2013-08-29 23:06 ` Francois Romieu
2013-08-29 23:06 ` Francois Romieu
2013-08-30 21:30 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2013-08-24 11:26 [PATCH] USB2NET : SR9700 : One chip " liujunliang_ljl-9Onoh4P/yGk
2013-08-24 18:15 ` Joe Perches
2013-08-28 21:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377837761.1928.139.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=liujunliang_ljl@163.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=sunhecheng@vip.126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).