From: Eric Dumazet <eric.dumazet@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] net: fix comment typo for __skb_alloc_pages()
Date: Fri, 30 Aug 2013 07:10:03 -0700 [thread overview]
Message-ID: <1377871803.7360.0.camel@edumazet-glaptop> (raw)
In-Reply-To: <1377869297-19805-1-git-send-email-f.fainelli@gmail.com>
On Fri, 2013-08-30 at 14:28 +0100, Florian Fainelli wrote:
> The name of the function in the comment is __skb_alloc_page() while we
> are actually commenting __skb_alloc_pages(). Fix this typo.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> include/linux/skbuff.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 5ac96f3..3a81e4b 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -1906,7 +1906,7 @@ static inline struct sk_buff *netdev_alloc_skb_ip_align(struct net_device *dev,
> }
>
> /*
> - * __skb_alloc_page - allocate pages for ps-rx on a skb and preserve pfmemalloc data
> + * __skb_alloc_pages - allocate pages for ps-rx on a skb and preserve pfmemalloc data
> * @gfp_mask: alloc_pages_node mask. Set __GFP_NOMEMALLOC if not for network packet RX
> * @skb: skb to set pfmemalloc on if __GFP_MEMALLOC is used
> * @order: size of the allocation
What about making this a real kerneldoc comment ?
/**
instead of
/*
next prev parent reply other threads:[~2013-08-30 14:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 13:28 [PATCH] net: fix comment typo for __skb_alloc_pages() Florian Fainelli
2013-08-30 14:10 ` Eric Dumazet [this message]
2013-08-30 14:18 ` Florian Fainelli
2013-08-30 14:36 ` [PATCH net-next] " Florian Fainelli
2013-09-04 2:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377871803.7360.0.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).