* [PATCH] net: fix comment typo for __skb_alloc_pages()
@ 2013-08-30 13:28 Florian Fainelli
2013-08-30 14:10 ` Eric Dumazet
2013-08-30 14:36 ` [PATCH net-next] " Florian Fainelli
0 siblings, 2 replies; 5+ messages in thread
From: Florian Fainelli @ 2013-08-30 13:28 UTC (permalink / raw)
To: netdev; +Cc: davem, Florian Fainelli
The name of the function in the comment is __skb_alloc_page() while we
are actually commenting __skb_alloc_pages(). Fix this typo.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
include/linux/skbuff.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 5ac96f3..3a81e4b 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -1906,7 +1906,7 @@ static inline struct sk_buff *netdev_alloc_skb_ip_align(struct net_device *dev,
}
/*
- * __skb_alloc_page - allocate pages for ps-rx on a skb and preserve pfmemalloc data
+ * __skb_alloc_pages - allocate pages for ps-rx on a skb and preserve pfmemalloc data
* @gfp_mask: alloc_pages_node mask. Set __GFP_NOMEMALLOC if not for network packet RX
* @skb: skb to set pfmemalloc on if __GFP_MEMALLOC is used
* @order: size of the allocation
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] net: fix comment typo for __skb_alloc_pages()
2013-08-30 13:28 [PATCH] net: fix comment typo for __skb_alloc_pages() Florian Fainelli
@ 2013-08-30 14:10 ` Eric Dumazet
2013-08-30 14:18 ` Florian Fainelli
2013-08-30 14:36 ` [PATCH net-next] " Florian Fainelli
1 sibling, 1 reply; 5+ messages in thread
From: Eric Dumazet @ 2013-08-30 14:10 UTC (permalink / raw)
To: Florian Fainelli; +Cc: netdev, davem
On Fri, 2013-08-30 at 14:28 +0100, Florian Fainelli wrote:
> The name of the function in the comment is __skb_alloc_page() while we
> are actually commenting __skb_alloc_pages(). Fix this typo.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> include/linux/skbuff.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 5ac96f3..3a81e4b 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -1906,7 +1906,7 @@ static inline struct sk_buff *netdev_alloc_skb_ip_align(struct net_device *dev,
> }
>
> /*
> - * __skb_alloc_page - allocate pages for ps-rx on a skb and preserve pfmemalloc data
> + * __skb_alloc_pages - allocate pages for ps-rx on a skb and preserve pfmemalloc data
> * @gfp_mask: alloc_pages_node mask. Set __GFP_NOMEMALLOC if not for network packet RX
> * @skb: skb to set pfmemalloc on if __GFP_MEMALLOC is used
> * @order: size of the allocation
What about making this a real kerneldoc comment ?
/**
instead of
/*
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: fix comment typo for __skb_alloc_pages()
2013-08-30 14:10 ` Eric Dumazet
@ 2013-08-30 14:18 ` Florian Fainelli
0 siblings, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2013-08-30 14:18 UTC (permalink / raw)
To: Eric Dumazet; +Cc: netdev, David Miller
2013/8/30 Eric Dumazet <eric.dumazet@gmail.com>:
> On Fri, 2013-08-30 at 14:28 +0100, Florian Fainelli wrote:
>> The name of the function in the comment is __skb_alloc_page() while we
>> are actually commenting __skb_alloc_pages(). Fix this typo.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> include/linux/skbuff.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
>> index 5ac96f3..3a81e4b 100644
>> --- a/include/linux/skbuff.h
>> +++ b/include/linux/skbuff.h
>> @@ -1906,7 +1906,7 @@ static inline struct sk_buff *netdev_alloc_skb_ip_align(struct net_device *dev,
>> }
>>
>> /*
>> - * __skb_alloc_page - allocate pages for ps-rx on a skb and preserve pfmemalloc data
>> + * __skb_alloc_pages - allocate pages for ps-rx on a skb and preserve pfmemalloc data
>> * @gfp_mask: alloc_pages_node mask. Set __GFP_NOMEMALLOC if not for network packet RX
>> * @skb: skb to set pfmemalloc on if __GFP_MEMALLOC is used
>> * @order: size of the allocation
>
> What about making this a real kerneldoc comment ?
Sure, I was not sure whether this deserved one or more patches, will
resend fixed.
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH net-next] net: fix comment typo for __skb_alloc_pages()
2013-08-30 13:28 [PATCH] net: fix comment typo for __skb_alloc_pages() Florian Fainelli
2013-08-30 14:10 ` Eric Dumazet
@ 2013-08-30 14:36 ` Florian Fainelli
2013-09-04 2:17 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Florian Fainelli @ 2013-08-30 14:36 UTC (permalink / raw)
To: netdev; +Cc: davem, Florian Fainelli
The name of the function in the comment is __skb_alloc_page() while we
are actually commenting __skb_alloc_pages(). Fix this typo and make it
a valid kernel doc comment.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
include/linux/skbuff.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 5ac96f3..6f1330a 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -1905,8 +1905,8 @@ static inline struct sk_buff *netdev_alloc_skb_ip_align(struct net_device *dev,
return __netdev_alloc_skb_ip_align(dev, length, GFP_ATOMIC);
}
-/*
- * __skb_alloc_page - allocate pages for ps-rx on a skb and preserve pfmemalloc data
+/**
+ * __skb_alloc_pages - allocate pages for ps-rx on a skb and preserve pfmemalloc data
* @gfp_mask: alloc_pages_node mask. Set __GFP_NOMEMALLOC if not for network packet RX
* @skb: skb to set pfmemalloc on if __GFP_MEMALLOC is used
* @order: size of the allocation
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net: fix comment typo for __skb_alloc_pages()
2013-08-30 14:36 ` [PATCH net-next] " Florian Fainelli
@ 2013-09-04 2:17 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2013-09-04 2:17 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev
From: "Florian Fainelli" <f.fainelli@gmail.com>
Date: Fri, 30 Aug 2013 15:36:14 +0100
> The name of the function in the comment is __skb_alloc_page() while we
> are actually commenting __skb_alloc_pages(). Fix this typo and make it
> a valid kernel doc comment.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-04 2:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-30 13:28 [PATCH] net: fix comment typo for __skb_alloc_pages() Florian Fainelli
2013-08-30 14:10 ` Eric Dumazet
2013-08-30 14:18 ` Florian Fainelli
2013-08-30 14:36 ` [PATCH net-next] " Florian Fainelli
2013-09-04 2:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).