From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Joe Perches <joe@perches.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Bruce Allan <bruce.w.allan@intel.com>,
Carolyn Wyborny <carolyn.wyborny@intel.com>,
Don Skidmore <donald.c.skidmore@intel.com>,
Greg Rose <gregory.v.rose@intel.com>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
Alex Duyck <alexander.h.duyck@intel.com>,
John Ronciak <john.ronciak@intel.com>,
Tushar Dave <tushar.n.dave@intel.com>,
e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i40e: Fix 32 bit shift compilation warnings
Date: Fri, 30 Aug 2013 19:12:36 -0700 [thread overview]
Message-ID: <1377915156.2030.40.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1377913655.2070.45.camel@joe-AO722>
[-- Attachment #1: Type: text/plain, Size: 544 bytes --]
On Fri, 2013-08-30 at 18:47 -0700, Joe Perches wrote:
> When dma_addr_t is a 32 bit value, >> 32 emits compiler warnings
> Use ((addr>>16) >>16) to avoid this.
>
> I presume the macro should actually use the kernel.h
> macro upper_32_bits() eventually.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_hmc.h | 2 +-
> drivers/net/ethernet/intel/i40e/i40e_type.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Thanks again, I will add this patch as well to my queue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-31 2:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 23:06 [PATCH 0/4] i40e: Neatening and object size reductions Joe Perches
2013-08-30 23:06 ` [PATCH 1/4] i40e: Whitespace cleaning Joe Perches
2013-08-30 23:06 ` [PATCH 2/4] i40e: Add and use pf_<level> Joe Perches
2013-08-30 23:06 ` [PATCH 3/4] i40e: pf_<level> remove "%s: " ... __func__ Joe Perches
2013-08-30 23:06 ` [PATCH 4/4] i40e: Convert pf_<level> macros to functions Joe Perches
2013-08-31 1:47 ` [PATCH] i40e: Fix 32 bit shift compilation warnings Joe Perches
2013-08-31 2:12 ` Jeff Kirsher [this message]
2013-08-31 16:45 ` [E1000-devel] " Stephen Hemminger
2013-08-31 2:12 ` [PATCH 0/4] i40e: Neatening and object size reductions Jeff Kirsher
2013-09-04 1:00 ` [E1000-devel] " Nelson, Shannon
2013-09-04 1:30 ` Joe Perches
2013-09-04 1:38 ` Nelson, Shannon
2013-09-04 4:31 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377915156.2030.40.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gregory.v.rose@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=joe@perches.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=tushar.n.dave@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).