From: Cong Wang <amwang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next v11 01/11] ipv6: move ip6_dst_hoplimit() into core kernel
Date: Sat, 31 Aug 2013 13:07:34 +0800 [thread overview]
Message-ID: <1377925654.29366.1.camel@cr0> (raw)
In-Reply-To: <20130831.005925.168719024280186075.davem@davemloft.net>
On Sat, 2013-08-31 at 00:59 -0400, David Miller wrote:
> From: Cong Wang <amwang@redhat.com>
> Date: Sat, 31 Aug 2013 11:07:18 +0800
>
> > @@ -75,3 +76,24 @@ int ip6_find_1stfragopt(struct sk_buff *skb, u8 **nexthdr)
> > return offset;
> > }
> > EXPORT_SYMBOL(ip6_find_1stfragopt);
> > +
> > +#if IS_ENABLED(CONFIG_IPV6)
> > +int ip6_dst_hoplimit(struct dst_entry *dst)
> ...
> > +#endif
> > +EXPORT_SYMBOL(ip6_dst_hoplimit);
>
> I don't think the export should be outside of the #if region.
>
> Did you test the build with IPV6 disabled?
Yes, but it didn't show me any error.
Below is my 3 config's for IPV6:
% grep IPV6 .config_ipv6_*
.config_ipv6_m:CONFIG_IPV6=m
.config_ipv6_m:CONFIG_IPV6_PRIVACY=y
.config_ipv6_m:CONFIG_IPV6_ROUTER_PREF=y
.config_ipv6_m:CONFIG_IPV6_ROUTE_INFO=y
.config_ipv6_m:CONFIG_IPV6_OPTIMISTIC_DAD=y
.config_ipv6_m:CONFIG_IPV6_MIP6=m
.config_ipv6_m:CONFIG_IPV6_SIT=m
.config_ipv6_m:CONFIG_IPV6_SIT_6RD=y
.config_ipv6_m:CONFIG_IPV6_NDISC_NODETYPE=y
.config_ipv6_m:CONFIG_IPV6_TUNNEL=m
.config_ipv6_m:CONFIG_IPV6_GRE=m
.config_ipv6_m:CONFIG_IPV6_MULTIPLE_TABLES=y
.config_ipv6_m:CONFIG_IPV6_SUBTREES=y
.config_ipv6_m:CONFIG_IPV6_MROUTE=y
.config_ipv6_m:CONFIG_IPV6_MROUTE_MULTIPLE_TABLES=y
.config_ipv6_m:CONFIG_IPV6_PIMSM_V2=y
.config_ipv6_m:CONFIG_NF_DEFRAG_IPV6=m
.config_ipv6_m:CONFIG_NF_CONNTRACK_IPV6=m
.config_ipv6_m:CONFIG_IP6_NF_MATCH_IPV6HEADER=m
.config_ipv6_m:CONFIG_NF_NAT_IPV6=m
.config_ipv6_n:# CONFIG_IPV6 is not set
.config_ipv6_y:CONFIG_IPV6=y
.config_ipv6_y:CONFIG_IPV6_PRIVACY=y
.config_ipv6_y:CONFIG_IPV6_ROUTER_PREF=y
.config_ipv6_y:CONFIG_IPV6_ROUTE_INFO=y
.config_ipv6_y:CONFIG_IPV6_OPTIMISTIC_DAD=y
.config_ipv6_y:CONFIG_IPV6_MIP6=y
.config_ipv6_y:CONFIG_IPV6_SIT=y
.config_ipv6_y:CONFIG_IPV6_SIT_6RD=y
.config_ipv6_y:CONFIG_IPV6_NDISC_NODETYPE=y
.config_ipv6_y:CONFIG_IPV6_TUNNEL=y
.config_ipv6_y:CONFIG_IPV6_GRE=y
.config_ipv6_y:CONFIG_IPV6_MULTIPLE_TABLES=y
.config_ipv6_y:CONFIG_IPV6_SUBTREES=y
.config_ipv6_y:CONFIG_IPV6_MROUTE=y
.config_ipv6_y:CONFIG_IPV6_MROUTE_MULTIPLE_TABLES=y
.config_ipv6_y:CONFIG_IPV6_PIMSM_V2=y
.config_ipv6_y:# CONFIG_IP_VS_IPV6 is not set
.config_ipv6_y:# CONFIG_NF_DEFRAG_IPV6 is not set
.config_ipv6_y:# CONFIG_NF_CONNTRACK_IPV6 is not set
next prev parent reply other threads:[~2013-08-31 5:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-31 3:07 [PATCH net-next v11 00/11] vxlan: add ipv6 support Cong Wang
2013-08-31 3:07 ` [PATCH net-next v11 01/11] ipv6: move ip6_dst_hoplimit() into core kernel Cong Wang
2013-08-31 4:59 ` David Miller
2013-08-31 5:07 ` Cong Wang [this message]
2013-08-31 5:56 ` David Miller
2013-08-31 3:07 ` [PATCH net-next v11 02/11] ipv6: move ip6_local_out " Cong Wang
2013-08-31 3:07 ` [PATCH net-next v11 03/11] ipv6: export a stub for IPv6 symbols used by vxlan Cong Wang
2013-08-31 3:07 ` [PATCH net-next v11 04/11] ipv6: export in6addr_loopback to modules Cong Wang
2013-08-31 3:07 ` [PATCH net-next v11 05/11] ipv6: do not call ndisc_send_rs() with write lock Cong Wang
2013-08-31 3:07 ` [PATCH net-next v11 06/11] vxlan: add ipv6 support Cong Wang
2013-08-31 3:07 ` [PATCH net-next v11 07/11] vxlan: add ipv6 route short circuit support Cong Wang
2013-08-31 3:07 ` [PATCH net-next v11 08/11] ipv6: move in6_dev_finish_destroy() into core kernel Cong Wang
2013-08-31 3:07 ` [PATCH net-next v11 09/11] vxlan: add ipv6 proxy support Cong Wang
2013-08-31 3:07 ` [PATCH net-next v11 10/11] ipv6: Add generic UDP Tunnel segmentation Cong Wang
2013-08-31 3:07 ` [PATCH net-next v11 11/11] net: unify skb_udp_tunnel_segment() and skb_udp6_tunnel_segment() Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377925654.29366.1.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).