From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Joe Perches <joe@perches.com>
Cc: Chas Williams <chas@cmf.nrl.navy.mil>,
linux-atm-general@lists.sourceforge.net,
inux Net Dev <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 2/2] atm: he: print MAC via %pM
Date: Tue, 03 Sep 2013 15:25:05 +0300 [thread overview]
Message-ID: <1378211105.22798.8.camel@smile> (raw)
In-Reply-To: <1378210806.2048.23.camel@joe-AO722>
On Tue, 2013-09-03 at 05:20 -0700, Joe Perches wrote:
> On Tue, 2013-09-03 at 15:13 +0300, Andy Shevchenko wrote:
> []
> > diff --git a/drivers/atm/he.c b/drivers/atm/he.c
> []
> > @@ -1088,15 +1088,8 @@ static int he_start(struct atm_dev *dev)
> > for (i = 0; i < 6; ++i)
> > dev->esi[i] = read_prom_byte(he_dev, MAC_ADDR + i);
> >
> > - hprintk("%s%s, %x:%x:%x:%x:%x:%x\n",
> > - he_dev->prod_id,
> > - he_dev->media & 0x40 ? "SM" : "MM",
> > - dev->esi[0],
> > - dev->esi[1],
> > - dev->esi[2],
> > - dev->esi[3],
> > - dev->esi[4],
> > - dev->esi[5]);
> > + hprintk("%s%s, %*pM\n", he_dev->prod_id,
> > + he_dev->media & 0x40 ? "SM" : "MM", dev->esi);
>
> %*pM?
>
> Did this compile cleanly?
See v2.1 of this patch, and sorry for this typo.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2013-09-03 12:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 12:13 [PATCH v2 1/2] atm: nicstar: re-use native mac_pton() helper Andy Shevchenko
2013-09-03 12:13 ` [PATCH v2 2/2] atm: he: print MAC via %pM Andy Shevchenko
2013-09-03 12:17 ` [PATCH v2.1] " Andy Shevchenko
2013-09-03 12:20 ` [PATCH v2 2/2] " Joe Perches
2013-09-03 12:25 ` Andy Shevchenko [this message]
2013-09-04 18:42 ` David Miller
2013-09-04 18:42 ` [PATCH v2 1/2] atm: nicstar: re-use native mac_pton() helper David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378211105.22798.8.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).