From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 2/2] atm: he: print MAC via %pM Date: Tue, 03 Sep 2013 15:25:05 +0300 Message-ID: <1378211105.22798.8.camel@smile> References: <1378210424-14781-1-git-send-email-andriy.shevchenko@linux.intel.com> <1378210424-14781-2-git-send-email-andriy.shevchenko@linux.intel.com> <1378210806.2048.23.camel@joe-AO722> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Cc: Chas Williams , linux-atm-general@lists.sourceforge.net, inux Net Dev , "David S . Miller" To: Joe Perches Return-path: Received: from mga03.intel.com ([143.182.124.21]:62408 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755324Ab3ICMZV convert rfc822-to-8bit (ORCPT ); Tue, 3 Sep 2013 08:25:21 -0400 In-Reply-To: <1378210806.2048.23.camel@joe-AO722> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2013-09-03 at 05:20 -0700, Joe Perches wrote: > On Tue, 2013-09-03 at 15:13 +0300, Andy Shevchenko wrote: > [] > > diff --git a/drivers/atm/he.c b/drivers/atm/he.c > [] > > @@ -1088,15 +1088,8 @@ static int he_start(struct atm_dev *dev) > > for (i = 0; i < 6; ++i) > > dev->esi[i] = read_prom_byte(he_dev, MAC_ADDR + i); > > > > - hprintk("%s%s, %x:%x:%x:%x:%x:%x\n", > > - he_dev->prod_id, > > - he_dev->media & 0x40 ? "SM" : "MM", > > - dev->esi[0], > > - dev->esi[1], > > - dev->esi[2], > > - dev->esi[3], > > - dev->esi[4], > > - dev->esi[5]); > > + hprintk("%s%s, %*pM\n", he_dev->prod_id, > > + he_dev->media & 0x40 ? "SM" : "MM", dev->esi); > > %*pM? > > Did this compile cleanly? See v2.1 of this patch, and sorry for this typo. -- Andy Shevchenko Intel Finland Oy