From: Joe Perches <joe@perches.com>
To: "Nelson, Shannon" <shannon.nelson@intel.com>
Cc: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [E1000-devel] [PATCH 0/4] i40e: Neatening and object size reductions
Date: Tue, 03 Sep 2013 21:31:29 -0700 [thread overview]
Message-ID: <1378269089.7347.59.camel@joe-AO722> (raw)
In-Reply-To: <FC41C24E35F18A40888AACA1A36F3E416C61C0E5@FMSMSX102.amr.corp.intel.com>
On Wed, 2013-09-04 at 01:00 +000, Nelson, Shannon wrote:
> we hadn't noticed the new experimental "--fix" option before. There
> are a lot of good suggestions there, but obviously it needs a lot of
> reading and tweaking before it can be used.
Yes, I think --fix works best on patches.
When you use -f and --fix together, it can do inappropriate things.
Using multiple passes of -f --fix --types=<ONE_SPECIFIC_TYPE> and
changing the "ONE_SPECIFIC_TYPE" can produce more reasonable patch
sequences.
If you do try it, and please remember it is experimental, do let me
know how well it works or doesn't work for you all.
Bug reports (and patches) welcome.
cheers, Joe
prev parent reply other threads:[~2013-09-04 4:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 23:06 [PATCH 0/4] i40e: Neatening and object size reductions Joe Perches
2013-08-30 23:06 ` [PATCH 1/4] i40e: Whitespace cleaning Joe Perches
2013-08-30 23:06 ` [PATCH 2/4] i40e: Add and use pf_<level> Joe Perches
2013-08-30 23:06 ` [PATCH 3/4] i40e: pf_<level> remove "%s: " ... __func__ Joe Perches
2013-08-30 23:06 ` [PATCH 4/4] i40e: Convert pf_<level> macros to functions Joe Perches
2013-08-31 1:47 ` [PATCH] i40e: Fix 32 bit shift compilation warnings Joe Perches
2013-08-31 2:12 ` Jeff Kirsher
2013-08-31 16:45 ` [E1000-devel] " Stephen Hemminger
2013-08-31 2:12 ` [PATCH 0/4] i40e: Neatening and object size reductions Jeff Kirsher
2013-09-04 1:00 ` [E1000-devel] " Nelson, Shannon
2013-09-04 1:30 ` Joe Perches
2013-09-04 1:38 ` Nelson, Shannon
2013-09-04 4:31 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378269089.7347.59.camel@joe-AO722 \
--to=joe@perches.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox