netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Govindarajulu Varadarajan <govindarajulu90@gmail.com>
To: davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: benve@cisco.com, ssujith@cisco.com, nistrive@cisco.com,
	umalhi@cisco.com,
	Govindarajulu Varadarajan <govindarajulu90@gmail.com>
Subject: [PATCH net-next 3/5] driver/net: enic: Try DMA 64 first, then failover to DMA
Date: Wed,  4 Sep 2013 11:17:16 +0530	[thread overview]
Message-ID: <1378273638-7780-4-git-send-email-govindarajulu90@gmail.com> (raw)
In-Reply-To: <1378273638-7780-1-git-send-email-govindarajulu90@gmail.com>

In servers with more than 1.1 TB of RAM, the existing 40/32 bit DMA
could cause failure as the DMA-able address could go outside the range
addressable using 40/32 bits.

The following patch first tried 64 bit DMA if possible, failover to 32
bit.

Signed-off-by: Sujith Sankar <ssujith@cisco.com>
Signed-off-by: Christian Benvenuti <benve@cisco.com>
Signed-off-by: Govindarajulu Varadarajan <govindarajulu90@gmail.com>
---
 drivers/net/ethernet/cisco/enic/enic_main.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
index 93898ba..7b756cf9 100644
--- a/drivers/net/ethernet/cisco/enic/enic_main.c
+++ b/drivers/net/ethernet/cisco/enic/enic_main.c
@@ -2080,11 +2080,11 @@ static int enic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	pci_set_master(pdev);
 
 	/* Query PCI controller on system for DMA addressing
-	 * limitation for the device.  Try 40-bit first, and
+	 * limitation for the device.  Try 64-bit first, and
 	 * fail to 32-bit.
 	 */
 
-	err = pci_set_dma_mask(pdev, DMA_BIT_MASK(40));
+	err = pci_set_dma_mask(pdev, DMA_BIT_MASK(64));
 	if (err) {
 		err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
 		if (err) {
@@ -2098,10 +2098,10 @@ static int enic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 			goto err_out_release_regions;
 		}
 	} else {
-		err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(40));
+		err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
 		if (err) {
 			dev_err(dev, "Unable to obtain %u-bit DMA "
-				"for consistent allocations, aborting\n", 40);
+				"for consistent allocations, aborting\n", 64);
 			goto err_out_release_regions;
 		}
 		using_dac = 1;
-- 
1.8.4

  parent reply	other threads:[~2013-09-04  5:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-04  5:47 [PATCH net-next 0/5] driver/net: enic: enic driver updates Govindarajulu Varadarajan
2013-09-04  5:47 ` [PATCH net-next 1/5] driver/net: enic: Add multi tx support for enic Govindarajulu Varadarajan
2013-09-04  5:47 ` [PATCH net-next 2/5] driver/net: enic: record q_number and rss_hash for skb Govindarajulu Varadarajan
2013-09-04  5:47 ` Govindarajulu Varadarajan [this message]
2013-09-04  6:01   ` [PATCH net-next 3/5] driver/net: enic: Try DMA 64 first, then failover to DMA Govindarajulu Varadarajan
2013-09-04  5:47 ` [PATCH net-next 4/5] driver/net: enic: Exposing symbols for Cisco's low latency driver Govindarajulu Varadarajan
2013-09-04 14:52   ` Ben Hutchings
2013-09-04 16:32     ` Christian Benvenuti (benve)
2013-09-04  5:47 ` [PATCH net-next 5/5] driver/net: enic: update enic maintainers and driver Govindarajulu Varadarajan
2013-09-05 16:40 ` [PATCH net-next 0/5] driver/net: enic: enic driver updates David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378273638-7780-4-git-send-email-govindarajulu90@gmail.com \
    --to=govindarajulu90@gmail.com \
    --cc=benve@cisco.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nistrive@cisco.com \
    --cc=ssujith@cisco.com \
    --cc=umalhi@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).