netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Todd Fujinaka <todd.fujinaka@intel.com>,
	netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next  1/9] igb: Don't look for a PBA in the iNVM when flashless
Date: Wed,  4 Sep 2013 06:08:48 -0700	[thread overview]
Message-ID: <1378300136-26003-2-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1378300136-26003-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Todd Fujinaka <todd.fujinaka@intel.com>

When a part is flashless, do not look for a PBA in the iNVM.

Signed-off-by: Todd Fujinaka <todd.fujinaka@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/igb/igb_main.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index df33c4b..78f49cf 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -2367,7 +2367,14 @@ static int igb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 			  "Width x1" : "unknown"), netdev->dev_addr);
 	}
 
-	ret_val = igb_read_part_string(hw, part_str, E1000_PBANUM_LENGTH);
+	if ((hw->mac.type >= e1000_i210 ||
+	     igb_get_flash_presence_i210(hw))) {
+		ret_val = igb_read_part_string(hw, part_str,
+					       E1000_PBANUM_LENGTH);
+	} else {
+		ret_val = -E1000_ERR_INVM_VALUE_NOT_FOUND;
+	}
+
 	if (ret_val)
 		strcpy(part_str, "Unknown");
 	dev_info(&pdev->dev, "%s: PBA No: %s\n", netdev->name, part_str);
-- 
1.8.3.1

  reply	other threads:[~2013-09-04 13:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-04 13:08 [net-next 0/9][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2013-09-04 13:08 ` Jeff Kirsher [this message]
2013-09-04 13:08 ` [net-next 2/9] igb: Implementation of 1-sec delay for i210 devices Jeff Kirsher
2013-09-04 13:08 ` [net-next 3/9] igb: New PHY_ID for i354 device Jeff Kirsher
2013-09-04 13:08 ` [net-next 4/9] igb: M88E1543 PHY downshift implementation Jeff Kirsher
2013-09-04 13:08 ` [net-next 5/9] igb: No PHPM support in i354 devices Jeff Kirsher
2013-09-04 13:08 ` [net-next 6/9] igb: Support to get 2_5G link status for appropriate media type Jeff Kirsher
2013-09-04 13:08 ` [net-next 7/9] igb: Get speed and duplex for 1G non_copper devices Jeff Kirsher
2013-09-04 13:08 ` [net-next 8/9] igb: Implementation to report advertised/supported link on i354 devices Jeff Kirsher
2013-09-04 13:08 ` [net-next 9/9] igb: Update version number Jeff Kirsher
2013-09-04 16:41 ` [net-next 0/9][pull request] Intel Wired LAN Driver Updates David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378300136-26003-2-git-send-email-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sassmann@redhat.com \
    --cc=todd.fujinaka@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).