From: Joe Perches <joe@perches.com>
To: Dave Jones <davej@redhat.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [rfc] suspicious indentation in do_tcp_setsockopt
Date: Wed, 04 Sep 2013 21:53:37 -0700 [thread overview]
Message-ID: <1378356817.1787.77.camel@joe-AO722> (raw)
In-Reply-To: <20130905044318.GA22806@redhat.com>
On Thu, 2013-09-05 at 00:43 -0400, Dave Jones wrote:
> On Thu, Sep 05, 2013 at 12:39:07AM -0400, David Miller wrote:
> > From: Dave Jones <davej@redhat.com>
> > Date: Thu, 5 Sep 2013 00:20:45 -0400
> >
> > > What's the intent here ?
> >
> > This stuff is great, do you have a script that looks for this false
> > indentation pattern?
>
> Coverity.
Good stuff.
> I'm doing daily builds with it now, in the hope of trying
> to catch things faster, but there's a *ton* of old stuff in there
> like this that needs sorting through, because it seems to have strange
> of notions of what a 'new' bug is.
I think scripts/coccinelle/misc/ifcol.cocci
does something similar.
next prev parent reply other threads:[~2013-09-05 4:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 4:20 [rfc] suspicious indentation in do_tcp_setsockopt Dave Jones
2013-09-05 4:39 ` David Miller
2013-09-05 4:43 ` Dave Jones
2013-09-05 4:53 ` Joe Perches [this message]
2013-09-05 7:42 ` Daniel Borkmann
2013-09-05 4:43 ` Joe Perches
2013-09-05 17:24 ` Neal Cardwell
2013-09-05 17:34 ` Yuchung Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378356817.1787.77.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=julia.lawall@lip6.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).