From: Joe Perches <joe@perches.com>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gospo@redhat.com" <gospo@redhat.com>,
"sassmann@redhat.com" <sassmann@redhat.com>
Subject: Re: [E1000-devel] [net-next v5 8/8] i40e: include i40e in kernel proper
Date: Thu, 05 Sep 2013 23:47:18 -0700 [thread overview]
Message-ID: <1378450038.19204.6.camel@joe-AO722> (raw)
In-Reply-To: <C0F8C5F1-0D98-4297-ACC9-55BB9C889FEB@intel.com>
On Fri, 2013-09-06 at 06:28 +0000, Brandeburg, Jesse wrote:
> On Sep 5, 2013, at 11:15 PM, "Stephen Hemminger" <stephen@networkplumber.org<mailto:stephen@networkplumber.org>> wrote:
>
> Dumb question why is this named Kbuild instead of Makefile like almost
> every other network driver?
>
> All the new kids are doing it, we'll at least that is what I thought when I made it.
>
> Re-reading https://www.kernel.org/doc/Documentation/kbuild/makefiles.txt
>
> I see that Makefile is preferred but Kbuild overrides Makefile.
>
> Either way works, but I would prefer not to rename it at this point but would gladly do so in a follow up patch
Please do.
I suppose it makes _some_ sense to use Kbuild in the
include paths but I think Makefile in places where
compilations are done is better.
next prev parent reply other threads:[~2013-09-06 6:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 6:01 [net-next v5 0/8][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2013-09-06 6:01 ` [net-next v5 1/8] i40e: main driver core Jeff Kirsher
2013-09-06 6:01 ` [net-next v5 2/8] i40e: transmit, receive, and NAPI Jeff Kirsher
2013-09-06 6:01 ` [net-next v5 3/8] i40e: driver ethtool core Jeff Kirsher
2013-09-06 6:01 ` [net-next v5 4/8] i40e: driver core headers Jeff Kirsher
2013-09-06 6:01 ` [net-next v5 5/8] i40e: implement virtual device interface Jeff Kirsher
2013-09-06 6:01 ` [net-next v5 6/8] i40e: init code and hardware support Jeff Kirsher
2013-09-06 6:01 ` [net-next v5 7/8] i40e: debugfs interface Jeff Kirsher
2013-09-06 6:01 ` [net-next v5 8/8] i40e: include i40e in kernel proper Jeff Kirsher
2013-09-06 6:14 ` Stephen Hemminger
2013-09-06 6:28 ` [E1000-devel] " Brandeburg, Jesse
2013-09-06 6:47 ` Joe Perches [this message]
2013-09-06 17:28 ` Williams, Mitch A
2013-09-06 17:39 ` Stephen Hemminger
2013-09-06 18:20 ` Joe Perches
2013-09-06 18:23 ` David Miller
2013-09-06 18:01 ` David Miller
2013-09-06 18:30 ` Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378450038.19204.6.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).