From: Eric Dumazet <eric.dumazet@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next] net: add documentation for BQL helpers
Date: Fri, 06 Sep 2013 08:18:26 -0700 [thread overview]
Message-ID: <1378480706.31445.26.camel@edumazet-glaptop> (raw)
In-Reply-To: <1378465119-1894-1-git-send-email-f.fainelli@gmail.com>
On Fri, 2013-09-06 at 11:58 +0100, Florian Fainelli wrote:
>
> +/**
> + * netdev_completed_queue - report bytes and packets completed by device
> + * @dev: network device
> + * @pkts: actual number of packets sent over the medium
> + * @bytes: actual number of bytes sent over the medium
> + *
> + * Report the number of bytes and packets transmitted by the network device
> + * hardware queue over the physical medium (without prepended/appended
> + * control blocks, FCS...)
Here, you should instead document that the @bytes must exactly match the
amount given in netdev_sent_queue(), or else BQL can panic.
(each queued skb accounts for X bytes on BQL, so at TX completion, same
X must be unaccounted)
next prev parent reply other threads:[~2013-09-06 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 10:58 [PATCH net-next] net: add documentation for BQL helpers Florian Fainelli
2013-09-06 13:03 ` Eric Dumazet
2013-09-06 13:56 ` Florian Fainelli
2013-09-06 15:18 ` Eric Dumazet [this message]
2013-09-06 15:58 ` [PATCH net-next v2] " Florian Fainelli
2013-09-06 16:09 ` Eric Dumazet
2013-09-06 18:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378480706.31445.26.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox